From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Shinya Kuribayashi" <skuribay@ruby.dti.ne.jp>, git@vger.kernel.org
Subject: Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly
Date: Fri, 5 Sep 2008 22:35:46 +0100 [thread overview]
Message-ID: <b0943d9e0809051435g23fa3b83u2a1e8f2a3a6b955f@mail.gmail.com> (raw)
In-Reply-To: <20080903162123.GA874@diana.vm.bytemark.co.uk>
2008/9/3 Karl Hasselström <kha@treskal.com>:
> On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:
>
>> diffcol.sh is based on Quilt, and Quilt is dependent on bash;
>> Actually all Quilt scripts use /bin/bash without exceptions. Then
>> it's good for diffcol.sh to use /bin/bash.
>
> Thanks for this, and the other patch you sent. I'll be picking them up
> this weekend, unless Catalin beats me to it.
BTW, I think at some point we could change to using Git's native
colouring. The diffcol.sh script is from the days when Git didn't have
this feature. We currently generate a diff string and pass it through
the pager but I'm not sure how to do this.
--
Catalin
prev parent reply other threads:[~2008-09-05 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 15:47 [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly Shinya Kuribayashi
2008-09-03 16:21 ` Karl Hasselström
2008-09-05 21:35 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0809051435g23fa3b83u2a1e8f2a3a6b955f@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=skuribay@ruby.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).