From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH] Do not crash if a patch log ref is missing
Date: Sun, 14 Sep 2008 22:01:55 +0100 [thread overview]
Message-ID: <b0943d9e0809141401o36b1347ctf6444a695b74a8b7@mail.gmail.com> (raw)
In-Reply-To: <20080914080839.GA30664@diana.vm.bytemark.co.uk>
On 14/09/2008, Karl Hasselström <kha@treskal.com> wrote:
> On 2008-09-12 22:54:58 +0100, Catalin Marinas wrote:
>
> > Since we'll get rid of the individual patch logs, StGit should
> > ignore if such a ref is missing when deleting the compatibility
> > patch files.
>
>
> I agree this is a good idea from a robustness perspective. Did you
> encounter a case where the deletion actually failed?
Yes, I was deleting some older patches and it happened for one of them
not to have a log reference. It left the stack in a pretty undefined
state (and used the stable StGit to delete the rest of the patches as
it is more tolerant :-)).
--
Catalin
prev parent reply other threads:[~2008-09-14 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 21:54 [StGit PATCH] Do not crash if a patch log ref is missing Catalin Marinas
2008-09-14 8:08 ` Karl Hasselström
2008-09-14 21:01 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0809141401o36b1347ctf6444a695b74a8b7@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).