git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Jon Smirl" <jonsmirl@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: Stgit and refresh-temp
Date: Sun, 23 Nov 2008 21:20:59 +0000	[thread overview]
Message-ID: <b0943d9e0811231320s804eff0k5aecbac84cb2ffe7@mail.gmail.com> (raw)
In-Reply-To: <20081112101439.GA27469@diana.vm.bytemark.co.uk>

2008/11/12 Karl Hasselström <kha@treskal.com>:
> On 2008-11-12 10:02:10 +0000, Catalin Marinas wrote:
>
>> I think it's just a matter of updating HEAD on the "merge_conflict"
>> path but I'm still not fully confident in modifying the new lib
>> infrastructure.
>
> You're probably right.

The simple patch below seems to fix it the goto issue. Could you
please confirm its correctness (the patch might be wrapped by the web
interface)?

diff --git a/stgit/lib/transaction.py b/stgit/lib/transaction.py
index 6623645..0f414d8 100644
--- a/stgit/lib/transaction.py
+++ b/stgit/lib/transaction.py
@@ -321,6 +321,7 @@ class StackTransaction(object):
         if any(getattr(cd, a) != getattr(orig_cd, a) for a in
                ['parent', 'tree', 'author', 'message']):
             comm = self.__stack.repository.commit(cd)
+            self.head = comm
         else:
             comm = None
             s = ' (unmodified)'

Thanks.

-- 
Catalin

  reply	other threads:[~2008-11-23 21:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 13:37 Stgit and refresh-temp Jon Smirl
2008-11-04 13:38 ` Jon Smirl
2008-11-04 14:50   ` Jon Smirl
2008-11-07  5:44 ` Karl Hasselström
2008-11-10 23:08   ` Jon Smirl
2008-11-10 23:10     ` Jon Smirl
2008-11-11 17:59   ` Catalin Marinas
2008-11-12  8:01     ` Karl Hasselström
2008-11-12 10:02       ` Catalin Marinas
2008-11-12 10:14         ` Karl Hasselström
2008-11-23 21:20           ` Catalin Marinas [this message]
2008-11-24 11:16             ` Karl Hasselström
2008-11-24 14:11               ` Jon Smirl
2008-11-12 12:46       ` Karl Hasselström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0811231320s804eff0k5aecbac84cb2ffe7@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonsmirl@gmail.com \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).