git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 5/5] Convert "float" to the lib infrastructure
Date: Mon, 16 Mar 2009 16:36:43 +0000	[thread overview]
Message-ID: <b0943d9e0903160936m1971fbaft928a495eaab4fa20@mail.gmail.com> (raw)
In-Reply-To: <20090313024137.GE15393@diana.vm.bytemark.co.uk>

2009/3/13 Karl Hasselström <kha@treskal.com>:
> On 2009-03-12 12:09:18 +0000, Catalin Marinas wrote:
>>  options = [
>>      opt('-s', '--series', action = 'store_true',
>> -        short = 'Rearrange according to a series file')]
>> +        short = 'Rearrange according to a series file')
>> +    ] + argparse.keep_option()
>
> This flag should take the filename as a parameter, both because it's
> the right thing to do and because it'll make the tab completion work
> right (as is, it'll complete on patch names after the -s flag).
>
> Something like
>
>  opt('-s', '--series', type = 'string')
>
> ought to do it.

This command was accepting series via the stdin as well (maybe for
easier use in other scripts or from stgit.el). Anyway, it doesn't seem
to make any difference with the bash completion. It still tries to
complete patches but when this fails bash lists files if the prefix
matches some.

-- 
Catalin

  reply	other threads:[~2009-03-16 16:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 12:08 [StGit PATCH 0/5] Various StGit patches Catalin Marinas
2009-03-12 12:08 ` [StGit PATCH 1/5] Check for local changes with "goto" Catalin Marinas
2009-03-13  1:57   ` Karl Hasselström
2009-03-16 14:56     ` Catalin Marinas
2009-03-17  7:06       ` Karl Hasselström
2009-03-17 10:51         ` Catalin Marinas
2009-03-17 13:36           ` Karl Hasselström
2009-03-12 12:09 ` [StGit PATCH 2/5] Add mergetool support to the classic StGit infrastructure Catalin Marinas
2009-03-13  2:02   ` Karl Hasselström
2009-03-12 12:09 ` [StGit PATCH 3/5] Add automatic git-mergetool invocation to the new infrastructure Catalin Marinas
2009-03-13  2:17   ` Karl Hasselström
2009-03-16 15:03     ` Catalin Marinas
2009-03-17  7:12       ` Karl Hasselström
2009-03-12 12:09 ` [StGit PATCH 4/5] Convert "sink" " Catalin Marinas
2009-03-13  2:27   ` Karl Hasselström
2009-03-12 12:09 ` [StGit PATCH 5/5] Convert "float" to the lib infrastructure Catalin Marinas
2009-03-13  2:41   ` Karl Hasselström
2009-03-16 16:36     ` Catalin Marinas [this message]
2009-03-17  7:16       ` Karl Hasselström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0903160936m1971fbaft928a495eaab4fa20@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).