From: Catalin Marinas <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 5/9] Convert 'hide' to the lib infrastructure
Date: Wed, 13 May 2009 17:08:02 +0100 [thread overview]
Message-ID: <b0943d9e0905130908x6ce569b7gddfc7c152989a618@mail.gmail.com> (raw)
In-Reply-To: <20090429062749.GE18483@diana.vm.bytemark.co.uk>
2009/4/29 Karl Hasselström <kha@treskal.com>:
> On 2009-04-28 16:10:03 +0100, Catalin Marinas wrote:
>
>> -args = [argparse.patch_range(argparse.applied_patches,
>> - argparse.unapplied_patches)]
>> +args = [argparse.patch_range(argparse.unapplied_patches)]
>
> Why not simply allow all patches? reorder_patches() below will happily
> pop unapplied patches before hiding them IIRC, and for already hidden
> patches you could just say "already hidden".
>
> Hmm, but this is for the tab completion, so I guess we'd only want the
> applied and unapplied patches here.
I fixed that in the proposed branch but I was to slow on sending e-mails.
> As I said,
>
> * Why not simply allow hiding of applied patches?
>
> * Hiding a hidden patch should probably be a warning (if that), not
> an error.
Fixed this as well.
--
Catalin
next prev parent reply other threads:[~2009-05-13 16:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 15:09 [StGit PATCH 0/9] Various StGit updates Catalin Marinas
2009-04-28 15:09 ` [StGit PATCH 1/9] Show "Pushing <patch>...done" when pushing a patch Catalin Marinas
2009-04-29 6:04 ` Karl Hasselström
2009-04-28 15:09 ` [StGit PATCH 2/9] Show some progress information when checking for upstream merges Catalin Marinas
2009-04-29 6:07 ` Karl Hasselström
2009-04-28 15:09 ` [StGit PATCH 3/9] Do not sleep after the last patch sent by e-mail Catalin Marinas
2009-04-29 6:13 ` Karl Hasselström
2009-04-28 15:09 ` [StGit PATCH 4/9] Convert 'clone' to the use stgit.lib Catalin Marinas
2009-04-29 6:21 ` Karl Hasselström
2009-05-13 16:10 ` Catalin Marinas
2009-04-28 15:10 ` [StGit PATCH 5/9] Convert 'hide' to the lib infrastructure Catalin Marinas
2009-04-29 6:27 ` Karl Hasselström
2009-05-13 16:08 ` Catalin Marinas [this message]
2009-04-28 15:10 ` [StGit PATCH 6/9] Convert 'unhide' " Catalin Marinas
2009-04-29 6:29 ` Karl Hasselström
2009-04-28 15:10 ` [StGit PATCH 7/9] Reinstate the --annotate option for refresh Catalin Marinas
2009-04-29 6:33 ` Karl Hasselström
2009-04-28 15:10 ` [StGit PATCH 8/9] Add the log --clear option Catalin Marinas
2009-04-29 6:35 ` Karl Hasselström
2009-04-28 15:10 ` [StGit PATCH 9/9] Use the default git colouring scheme rather than specific scripts Catalin Marinas
2009-04-29 6:43 ` Karl Hasselström
2009-04-29 11:48 ` Samuel Tardieu
2009-04-29 11:56 ` Samuel Tardieu
2009-04-29 14:25 ` Karl Hasselström
2009-05-04 12:48 ` Shinya Kuribayashi
2009-05-29 12:22 ` Catalin Marinas
2009-05-30 0:36 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0905130908x6ce569b7gddfc7c152989a618@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).