git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Karl Hasselström" <kha@treskal.com>,
	"John Kacur" <jkacur@gmail.com>
Subject: Re: [ANNOUNCE] Stacked Git 0.15-rc1
Date: Tue, 14 Jul 2009 15:12:49 +0100	[thread overview]
Message-ID: <b0943d9e0907140712i39818abfldd01b8f8bb0fe301@mail.gmail.com> (raw)
In-Reply-To: <20090713082859.GA10549@pengutronix.de>

2009/7/13 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
>        stg goto include-linux-delay-h-in-hwlat_detector.patch
>        git show --stat
>
> yields:
>
>        commit 12c06d44017a9c51746290779fc24fb8d69c68ef
>        Author: Uwe Kleine-König <=?utf-8?q?Uwe=20Kleine-K=C3=B6nig?=>
>        Date:   Mon Jul 13 10:01:19 2009 +0200
>
>            Subject: include linux/delay.h in hwlat_detector
>                <u.kleine-koenig@pengutronix.de>
>            Date: Sun, 14 Jun 2009 23:31:42 +0200
>
>            This broke when compiling on i386 without X86_LOCAL_APIC because then
>            arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
>            linux/delay.h.
>
>            Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>            Cc: Jon Masters <jcm@redhat.com>
>            LKML-Reference: <1245015102-22057-1-git-send-email-u.kleine-koenig@pengutron
>            Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>            Cc: Thomas Gleixner <tglx@linutronix.de>
>            Cc: Jon Masters <jcm@redhat.com>
>
>         drivers/misc/hwlat_detector.c |    1 +
>         1 files changed, 1 insertions(+), 0 deletions(-)
>
> There are some things to enhance:
>
>  - s/Subject: //
>  - use Date line as author date
>  - stray email address
>  - author ident is wrong/broken

Can you try stg import -m? If all the patches have Subject: (From:
etc.), git show displays:

commit 7718bb00156313687ae42c3ae9d157c558bacb15
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date:   Sun Jun 14 23:31:42 2009 +0200

    include linux/delay.h in hwlat_detector

    This broke when compiling on i386 without X86_LOCAL_APIC because then
    arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
    linux/delay.h.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Jon Masters <jcm@redhat.com>
    LKML-Reference: <1245015102-22057-1-git-send-email-u.kleine-koenig@pengutron
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Jon Masters <jcm@redhat.com>


If there are mixed patches, we may need some kind of autodetection but
it seems that most rt patches follow this rule. If there is no
description (kbuild.patch), stgit seems to insert None.

-- 
Catalin

  reply	other threads:[~2009-07-14 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 22:40 [ANNOUNCE] Stacked Git 0.15-rc1 Catalin Marinas
2009-07-13  8:28 ` Uwe Kleine-König
2009-07-14 14:12   ` Catalin Marinas [this message]
2009-07-13 13:10 ` Karl Wiberg
2009-07-13 13:33 ` Aneesh Kumar K.V
2009-07-13 17:07   ` Catalin Marinas
2009-07-13 17:20     ` Aneesh Kumar K.V
2009-07-13 17:47       ` Aneesh Kumar K.V
2009-07-13 22:06         ` Catalin Marinas
2009-07-13 22:57           ` Linus Torvalds
2009-07-14  8:24             ` Catalin Marinas
2009-07-14 17:52 ` Larry D'Anna
2009-07-14 21:05   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0907140712i39818abfldd01b8f8bb0fe301@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jkacur@gmail.com \
    --cc=kha@treskal.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).