From: Catalin Marinas <catalin.marinas@gmail.com>
To: Karl Wiberg <kha@treskal.com>
Cc: "Gustav Hållberg" <gustav@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [StGit PATCH] Add import -p option
Date: Wed, 9 Sep 2009 23:09:51 +0100 [thread overview]
Message-ID: <b0943d9e0909091509i16b556f0x9dd3aa6788054298@mail.gmail.com> (raw)
In-Reply-To: <20090908223714.GA6364@diana.vm.bytemark.co.uk>
2009/9/8 Karl Wiberg <kha@treskal.com>:
> On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote:
>
>> This patch renames some of the existing import options and adds the
>> -p (--strip) option which allows stripping the leading slashes of
>> the diff paths.
>
> Looks good (and the intent is very good). The import test should
> probably be augmented with a test case for -pN, though.
Yes. I'll try to add one. As you noticed, not all options are tested.
>> + if strip:
>> + cmd += ['-p', strip]
>
> This test should probably be "if strip != None". It doesn't _really_
> matter, technically, since -p0 is the default, but still ...
I modified it after posting the patch. The git default is -p1, so we
would miss the -p0 case.
--
Catalin
next prev parent reply other threads:[~2009-09-09 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 21:43 [StGit PATCH] Add import -p option Catalin Marinas
2009-09-08 22:37 ` Karl Wiberg
2009-09-09 22:09 ` Catalin Marinas [this message]
2009-09-10 8:24 ` Karl Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0909091509i16b556f0x9dd3aa6788054298@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gustav@gmail.com \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).