git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@gmail.com>
To: Karl Wiberg <kha@treskal.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] Stacked Git 0.15
Date: Mon, 26 Oct 2009 16:23:06 +0000	[thread overview]
Message-ID: <b0943d9e0910260923v77c457f8w2d56d8c06f71e965@mail.gmail.com> (raw)
In-Reply-To: <20091026134915.GA1565@diana.vm.bytemark.co.uk>

2009/10/26 Karl Wiberg <kha@treskal.com>:
> On 2009-10-26 10:32:07 +0000, Catalin Marinas wrote:
>> The problem was a bit more complicated than this. Some files are
>> generated by the Makefile rather than setup.py so using the latter
>> directly fails to build anything.
>>
>> So it's time for 0.15.1 this week with the fix below (in my
>> "proposed" branch). I cc'ed Karl as well in case he has time to have
>> a quick look.
>
> I don't have any objections, except ...
[...]
>> -test: build
>> +test:
>>       cd t && $(MAKE) all
>
> ... don't we need to run "setup.py build" here in order to not change
> the behavior?

Good point. I updated the patch in the "proposed" branch.

Thanks.

-- 
Catalin

  reply	other threads:[~2009-10-26 16:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-24 22:41 [ANNOUNCE] Stacked Git 0.15 Catalin Marinas
2009-10-24 23:20 ` Jakub Narebski
2009-10-25 17:13   ` Catalin Marinas
2009-10-26 10:32     ` Catalin Marinas
2009-10-26 13:49       ` Karl Wiberg
2009-10-26 16:23         ` Catalin Marinas [this message]
2009-11-02 10:05 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0910260923v77c457f8w2d56d8c06f71e965@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).