From: "Gustavo Sverzut Barbieri" <barbieri@profusion.mobi>
To: "Petr Baudis" <pasky@suse.cz>
Cc: git@vger.kernel.org, "Jakub Narebski" <jnareb@gmail.com>
Subject: Re: [PATCH 0/2] gitweb use sections
Date: Sun, 10 Aug 2008 16:45:14 -0300 [thread overview]
Message-ID: <b1f2b8c40808101245j2942dc70sa429cca05c1bb5c7@mail.gmail.com> (raw)
In-Reply-To: <b1f2b8c40807311358k4132ba8bw931279d7a6a7bcb5@mail.gmail.com>
Yet another "ping" on this topic, news?
On Thu, Jul 31, 2008 at 5:58 PM, Gustavo Sverzut Barbieri
<barbieri@profusion.mobi> wrote:
> On Thu, Jul 31, 2008 at 5:32 PM, Petr Baudis <pasky@suse.cz> wrote:
>> Hi,
>>
>> On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
>>> Since nobody replied and I missed some gitweb guys in CC, I'm adding
>>> Petr and Jakub, as some guys said on IRC.
>>>
>>> Have anyone tried this patch, any problems?
>>
>> sorry, I have it in my review queue. At first pass it was looking
>> good, but I wanted to look at it better before commenting.
>
> no problem, just to see it was noticed or not :-)
>
>
>> One thing I'm wondering about is how to make this stuff configurable,
>> since I'm not very comfortable with adding more "unbound" configuration
>> variables and would rather prefer stuff to be added to the $features
>> array... I'm not at all sure about my own sentiment here, however.
>
> Path comparison (first patch), Sections (second), both?
>
> I know path comparison can be a performance hit on large listings on
> sites with heavy traffic. However, I don't see many people accessing
> the projects page at the same time for long periods, it's not like
> slashdot... people mostly use it to know about repositories and then
> use git to track it.
> The slowness is due O(n^2) worst case of sort and each step is not
> a bit heavier since it need to split path into components and walk
> these. Maybe cache the split?
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: barbieri@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbieri@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
prev parent reply other threads:[~2008-08-10 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 2:34 [PATCH 0/2] gitweb use sections Gustavo Sverzut Barbieri
2008-07-29 2:34 ` [PATCH 1/2] gitweb: sort projects by path Gustavo Sverzut Barbieri
2008-07-29 2:34 ` [PATCH 2/2] gitweb: add section support to gitweb project listing Gustavo Sverzut Barbieri
2008-07-29 3:59 ` [PATCH 1/2 v2] gitweb: sort projects by path Gustavo Sverzut Barbieri
2008-07-31 19:43 ` [PATCH 0/2] gitweb use sections Gustavo Sverzut Barbieri
2008-07-31 20:32 ` Petr Baudis
2008-07-31 20:58 ` Gustavo Sverzut Barbieri
2008-08-10 19:45 ` Gustavo Sverzut Barbieri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1f2b8c40808101245j2942dc70sa429cca05c1bb5c7@mail.gmail.com \
--to=barbieri@profusion.mobi \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).