git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eli Schwartz <eschwartz93@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	Henrik Holst <henrik.holst@outlook.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: ./configure fails to link test program due to missing dependencies
Date: Tue, 24 Sep 2024 10:31:08 -0400	[thread overview]
Message-ID: <b28b1256-01bc-46a3-8338-e47f2301eccf@gmail.com> (raw)
In-Reply-To: <xmqqldzsrhyp.fsf@gitster.g>


[-- Attachment #1.1: Type: text/plain, Size: 1673 bytes --]

On 9/15/24 12:37 PM, Junio C Hamano wrote:
> Looking at configure.ac, pkg-config is not used for any package.
> Specifically for curl, it seems that "curl-config --libs" is used.
> 
> Presumably the reason behind the current behaviour is combination of
> (1) ./configure is an after-thought in the build infrastructure for
> this project, (2) pkg-config was not ubiquitous back when autoconf
> support was written for this project, and (3) nobody considered
> "upgrading" our use of "curl-config" and our manual detection of
> dependency detection for other libraries to just use "pkg-config".
> 
> Patches welcome ;-)


As an aside: I am skeptical of this explanation.

pkg-config's first git commit in 2005 is an import of a 2001 commit from
another version control system (probably GNU Arch -- author "Arch
Librarian"). The changelog it includes starts a year earlier, in 2000.
Wikipedia agrees, claiming the initial release of pkg-config was in 2000
and citing gtk-devel mailing list discussions from June of that year.

git added a configure.ac script 6 years later. Curl itself had installed
a .pc file for 7 months at that time, and OpenSSL had installed one for
nearly 4 years.

But git's configure script looked -- and still looks -- for -lcurl only
to set NO_CURL for the Makefile. In 2018, ./configure started using
curl-config, in order to set CURL_LDFLAGS.

I suppose it was copied by rote from the Makefile, which has less
flexibility to try pkg-config and fall back to curl-config.

Part 1 of the explanation is valid: ./configure was an after-thought. :)


-- 
Eli Schwartz
Gentoo Developer and Meson Build maintainer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

      parent reply	other threads:[~2024-09-24 14:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-14 22:57 ./configure fails to link test program due to missing dependencies Henrik Holst
2024-09-15 16:37 ` Junio C Hamano
2024-09-15 16:47   ` brian m. carlson
2024-09-16  7:50   ` Patrick Steinhardt
2024-09-18 10:04     ` Phillip Wood
2024-09-18 22:39       ` Junio C Hamano
2024-09-24 12:10         ` Patrick Steinhardt
2024-09-24 13:59           ` Eli Schwartz
2024-09-24 14:25             ` Paul Smith
2024-09-25  4:36             ` Patrick Steinhardt
2024-09-25  6:02               ` Eli Schwartz
2024-09-25  6:04                 ` Patrick Steinhardt
2024-09-26 13:55                   ` Phillip Wood
2024-09-26 14:02                     ` Patrick Steinhardt
2024-09-27 10:10                       ` Phillip Wood
2024-09-26 16:04                     ` Eli Schwartz
2024-09-27 10:00                       ` phillip.wood123
2024-09-26 16:22                     ` Junio C Hamano
2024-09-29 17:56                       ` Johannes Schindelin
2024-09-29 18:10                         ` Eli Schwartz
2024-09-30  8:50                           ` Phillip Wood
2024-09-30 13:57                             ` Eli Schwartz
2024-09-30 16:31                               ` Junio C Hamano
2024-09-30 16:05                             ` Johannes Schindelin
2024-09-25 19:15                 ` Patrick Steinhardt
2024-09-25 19:17                   ` Patrick Steinhardt
2024-09-24 17:39           ` Junio C Hamano
2024-09-25 15:33             ` Paul Smith
2024-09-26  1:35               ` Eli Schwartz
2024-09-26 19:42                 ` Paul Smith
2024-09-24 14:31   ` Eli Schwartz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b28b1256-01bc-46a3-8338-e47f2301eccf@gmail.com \
    --to=eschwartz93@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=henrik.holst@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).