From: David Turner <David.Turner@twosigma.com>
To: 'Stefan Beller' <sbeller@google.com>,
"gitster@pobox.com" <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: RE: [PATCH] unpack-trees: fix grammar for untracked files in directories
Date: Fri, 2 Dec 2016 19:23:24 +0000 [thread overview]
Message-ID: <b2fedf5bad754cd0b6f23e83a415b731@exmbdft7.ad.twosigma.com> (raw)
In-Reply-To: <20161202191741.12693-1-sbeller@google.com>
LGTM.
> -----Original Message-----
> From: Stefan Beller [mailto:sbeller@google.com]
> Sent: Friday, December 02, 2016 2:18 PM
> To: gitster@pobox.com
> Cc: git@vger.kernel.org; David Turner; Stefan Beller
> Subject: [PATCH] unpack-trees: fix grammar for untracked files in
> directories
>
> Noticed-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>
> This was noticed by David when reviewing the submodule checkout series,
> though rolling this as an independent fix is better :)
>
> Thanks,
> Stefan
>
> t/t7609-merge-co-error-msgs.sh | 2 +-
> unpack-trees.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7609-merge-co-error-msgs.sh b/t/t7609-merge-co-error-
> msgs.sh index f80bdb81e1..e90413204e 100755
> --- a/t/t7609-merge-co-error-msgs.sh
> +++ b/t/t7609-merge-co-error-msgs.sh
> @@ -105,7 +105,7 @@ test_expect_success 'not uptodate file porcelain
> checkout error' '
> '
>
> cat >expect <<\EOF
> -error: Updating the following directories would lose untracked files in
> it:
> +error: Updating the following directories would lose untracked files in
> them:
> rep
> rep2
>
> diff --git a/unpack-trees.c b/unpack-trees.c index ea6bdd20e0..7a6df99d10
> 100644
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
> @@ -78,7 +78,7 @@ void setup_unpack_trees_porcelain(struct
> unpack_trees_options *opts,
> xstrfmt(msg, cmd, cmd);
>
> msgs[ERROR_NOT_UPTODATE_DIR] =
> - _("Updating the following directories would lose untracked
> files in it:\n%s");
> + _("Updating the following directories would lose untracked
> files in
> +them:\n%s");
>
> if (!strcmp(cmd, "checkout"))
> msg = advice_commit_before_merge
> --
> 2.10.2.613.g22f2156
prev parent reply other threads:[~2016-12-02 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:17 [PATCH] unpack-trees: fix grammar for untracked files in directories Stefan Beller
2016-12-02 19:23 ` David Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2fedf5bad754cd0b6f23e83a415b731@exmbdft7.ad.twosigma.com \
--to=david.turner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).