From: Derrick Stolee <stolee@gmail.com>
To: Sam Bostock via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>, Sam Bostock <sam@sambostock.ca>
Subject: Re: [PATCH v2 0/2] merge-ours: sparse-index integration
Date: Mon, 9 Feb 2026 23:35:48 -0500 [thread overview]
Message-ID: <b365b5a8-b66c-40ac-bd85-a57aa9fa7d12@gmail.com> (raw)
In-Reply-To: <pull.2189.v2.git.git.1770405383.gitgitgadget@gmail.com>
On 2/6/2026 2:16 PM, Sam Bostock via GitGitGadget wrote:
> This short series teaches merge-ours to work with a sparse index as a small
> step toward broader sparse-index support.
>
> Patch 1 is a preparatory cleanup that converts merge-ours away from
> the_repository global, using the repo parameter instead.
>
> Patch 2 adds the actual sparse-index integration and tests.
Thanks for working in this area. We have a long tail of instances where
the sparse-index could be integrated at its most bare-minimum case.
> Developed with AI assistance (Claude).
My experiments with such tools seem to do well when there are clear
examples of how to make tests and how to make appropriate fixes. The
tests added to t1092 follow the standard model for checking that
the index isn't expanded. Perhaps the many cases we have for these
integrations could be tackled more easily with such tools. I expect
that they are _mostly_ boilerplate tests and minor fixes (but don't
look too closely at 'git mv' which doesn't have clear patterns with
sparse-checkout even with a full index).
The one thing I didn't see that we normally see is a case where the
sparse index _is_ expanded, but that shouldn't happen with the 'ours'
strategy! Excellent.
These patches LGTM.
Thanks,
-Stolee
prev parent reply other threads:[~2026-02-10 4:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 2:32 [PATCH 0/2] merge-ours: sparse-index integration Sam Bostock via GitGitGadget
2026-02-06 2:32 ` [PATCH 1/2] merge-ours: drop USE_THE_REPOSITORY_VARIABLE Sam Bostock via GitGitGadget
2026-02-06 15:02 ` Patrick Steinhardt
2026-02-06 17:33 ` Junio C Hamano
2026-02-06 2:32 ` [PATCH 2/2] merge-ours: integrate with sparse-index Sam Bostock via GitGitGadget
2026-02-06 13:35 ` Junio C Hamano
2026-02-06 19:16 ` [PATCH v2 0/2] merge-ours: sparse-index integration Sam Bostock via GitGitGadget
2026-02-06 19:16 ` [PATCH v2 1/2] merge-ours: drop USE_THE_REPOSITORY_VARIABLE Sam Bostock via GitGitGadget
2026-02-06 19:16 ` [PATCH v2 2/2] merge-ours: integrate with sparse-index Sam Bostock via GitGitGadget
2026-02-09 15:05 ` [PATCH v2 0/2] merge-ours: sparse-index integration Patrick Steinhardt
2026-02-10 4:35 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b365b5a8-b66c-40ac-bd85-a57aa9fa7d12@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
--cc=sam@sambostock.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox