From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 270991F405 for ; Thu, 9 Aug 2018 09:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730374AbeHIMFP (ORCPT ); Thu, 9 Aug 2018 08:05:15 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39927 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729880AbeHIMFP (ORCPT ); Thu, 9 Aug 2018 08:05:15 -0400 Received: by mail-pg1-f193.google.com with SMTP id a11-v6so2495587pgw.6 for ; Thu, 09 Aug 2018 02:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:in-reply-to:references:from:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=Ptbvr5bQaWavSlc8UMin4hZ6TJEfHjE4a8TJbL+YowM=; b=ozoQw6hZvta8rvB5qtltZfIF17UOIzSONBOIYU/MHuyN3kuDCJb1oOKa+MsfDDYz7x SuQcBx3e4lj7F4cagJN0vD91lPtcks0x5BSiI2gJ/b3XgUuvQ+3XlBmo3auOUS0i354/ 1i3X562GesXkfwkBUYRbTUAXE7eCtmIm4YXXjbIwB4qpS9kGyQnTUxD78EdybHdNxaWH +ASwGm4hw7D0uqCpsa8j6zM8T5MviHnSq2yQ8/1BY5ShCS1kFXskIrFcMixH0MUNxE5T Wk6lqCav60ECbvg6z21iB6raM6j5zVPW48lwLGweZ4TGMfRCEotLcuvHYp7JaNVD6NAn YrsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:in-reply-to:references:from :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=Ptbvr5bQaWavSlc8UMin4hZ6TJEfHjE4a8TJbL+YowM=; b=SDaiqFJMUKVYxfDC19Km2I4CjjlTaLPwQWhuJZKaz6L3HuW4p8HlSBMj9/69S/GHQY dWDzBBeolmZXx6IV9a0BtYVN6V4p6em2aUpog965hqbjtZy892Yy2A6CKoja/miifffY FbiYW2pN2iUfysZzC7anrIux1TGwK+hrDBH7peIbR1MjpG8fAkxgqGUf8Y6bVwY2p4/+ 5x8wk55wiWEPx1FNu2uXSGJlq94MykJR45cG+/ooyRaWP6gaZWkPQa+7NyPS034B3jWV 9vZT9nATdQrGBCADcRWPAGQuCQw92rJFOO4voFhIW016IcXYLkvxyOnZ2clKI/pVVtLg 6bmg== X-Gm-Message-State: AOUpUlFoBrgcW7S/zJFYXKjunAI7DqMe+LeghpZt73KxW4zuH6mKsz+s xnljt+eEQ2nmuWGz8MmoBqFUBh1j X-Google-Smtp-Source: AA+uWPw290PQuH0XniNvHBzTIEjUoS9zmZpuGcRBylGdoObsHedHRuwOwr5zzotxXslvHP6nhigM1Q== X-Received: by 2002:a65:62d8:: with SMTP id m24-v6mr1433786pgv.307.1533807672433; Thu, 09 Aug 2018 02:41:12 -0700 (PDT) Received: from [127.0.0.1] ([40.112.142.204]) by smtp.gmail.com with ESMTPSA id d19-v6sm19167067pfm.48.2018.08.09.02.41.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 02:41:11 -0700 (PDT) Date: Thu, 09 Aug 2018 02:41:11 -0700 (PDT) X-Google-Original-Date: Thu, 09 Aug 2018 09:41:06 GMT Message-Id: In-Reply-To: References: From: "Johannes Schindelin via GitGitGadget" Subject: [PATCH v3 2/2] rebase --exec: make it work with --rebase-merges Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Johannes Schindelin The idea of `--exec` is to append an `exec` call after each `pick`. Since the introduction of fixup!/squash! commits, this idea was extended to apply to "pick, possibly followed by a fixup/squash chain", i.e. an exec would not be inserted between a `pick` and any of its corresponding `fixup` or `squash` lines. The current implementation uses a dirty trick to achieve that: it assumes that there are only pick/fixup/squash commands, and then *inserts* the `exec` lines before any `pick` but the first, and appends a final one. With the todo lists generated by `git rebase --rebase-merges`, this simple implementation shows its problems: it produces the exact wrong thing when there are `label`, `reset` and `merge` commands. Let's change the implementation to do exactly what we want: look for `pick` lines, skip any fixup/squash chains, and then insert the `exec` line. Lather, rinse, repeat. Note: we take pains to insert *before* comment lines whenever possible, as empty commits are represented by commented-out pick lines (and we want to insert a preceding pick's exec line *before* such a line, not afterward). While at it, also add `exec` lines after `merge` commands, because they are similar in spirit to `pick` commands: they add new commits. Signed-off-by: Johannes Schindelin --- sequencer.c | 42 +++++++++++++++++++++++++++++----------- t/t3430-rebase-merges.sh | 2 +- 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/sequencer.c b/sequencer.c index 31038472f..278d34ce9 100644 --- a/sequencer.c +++ b/sequencer.c @@ -4244,10 +4244,9 @@ int sequencer_add_exec_commands(const char *commands) { const char *todo_file = rebase_path_todo(); struct todo_list todo_list = TODO_LIST_INIT; - struct todo_item *item; struct strbuf *buf = &todo_list.buf; size_t offset = 0, commands_len = strlen(commands); - int i, first; + int i, insert; if (strbuf_read_file(&todo_list.buf, todo_file, 0) < 0) return error(_("could not read '%s'."), todo_file); @@ -4257,19 +4256,40 @@ int sequencer_add_exec_commands(const char *commands) return error(_("unusable todo list: '%s'"), todo_file); } - first = 1; - /* insert before every pick except the first one */ - for (item = todo_list.items, i = 0; i < todo_list.nr; i++, item++) { - if (item->command == TODO_PICK && !first) { - strbuf_insert(buf, item->offset_in_buf + offset, - commands, commands_len); + /* + * Insert after every pick. Here, fixup/squash chains + * are considered part of the pick, so we insert the commands *after* + * those chains if there are any. + */ + insert = -1; + for (i = 0; i < todo_list.nr; i++) { + enum todo_command command = todo_list.items[i].command; + + if (insert >= 0) { + /* skip fixup/squash chains */ + if (command == TODO_COMMENT) + continue; + else if (is_fixup(command)) { + insert = i + 1; + continue; + } + strbuf_insert(buf, + todo_list.items[insert].offset_in_buf + + offset, commands, commands_len); offset += commands_len; + insert = -1; } - first = 0; + + if (command == TODO_PICK || command == TODO_MERGE) + insert = i + 1; } - /* append final */ - strbuf_add(buf, commands, commands_len); + /* insert or append final */ + if (insert >= 0 && insert < todo_list.nr) + strbuf_insert(buf, todo_list.items[insert].offset_in_buf + + offset, commands, commands_len); + else if (insert >= 0 || !offset) + strbuf_add(buf, commands, commands_len); i = write_message(buf->buf, buf->len, todo_file, 0); todo_list_release(&todo_list); diff --git a/t/t3430-rebase-merges.sh b/t/t3430-rebase-merges.sh index 0bf5eaa37..90ae613e2 100755 --- a/t/t3430-rebase-merges.sh +++ b/t/t3430-rebase-merges.sh @@ -363,7 +363,7 @@ test_expect_success 'octopus merges' ' EOF ' -test_expect_failure 'with --autosquash and --exec' ' +test_expect_success 'with --autosquash and --exec' ' git checkout -b with-exec H && echo Booh >B.t && test_tick && -- gitgitgadget