From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] maintenance: test commit-graph auto condition
Date: Wed, 7 Oct 2020 20:13:32 -0400 [thread overview]
Message-ID: <b4918483-5ce6-b002-77dc-92d3049f2069@gmail.com> (raw)
In-Reply-To: <xmqqblhd23dc.fsf@gitster.c.googlers.com>
On 10/7/2020 4:22 PM, Junio C Hamano wrote:
> Hmph. Something in ds/maintenance-part-2 series does not seem to
> work well with this change. I noticed it when testing today's first
> integration cycle of jch and seen branches, but even when applied to
> ds/maintenance-part-2 alone without any other topics in seen, it
> seems to break in an unexpected place.
Thank you for alerting me to this. I should have ran the tests after
merging with the other branches in progress.
It seems my issue is that I use "test_commit one" in two places now,
so the second complains that nothing is new to commit.
The simplest fix is to use "first", "second", and "third" in this
patch, so I'll send a v2 soon with that change.
Thanks,
-Stolee
next prev parent reply other threads:[~2020-10-08 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 12:55 [PATCH] maintenance: test commit-graph auto condition Derrick Stolee via GitGitGadget
2020-10-07 20:22 ` Junio C Hamano
2020-10-08 0:13 ` Derrick Stolee [this message]
2020-10-08 0:50 ` [PATCH v2] " Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4918483-5ce6-b002-77dc-92d3049f2069@gmail.com \
--to=stolee@gmail.com \
--cc=derrickstolee@github.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).