git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: git@vger.kernel.org
Subject: [Suggestion] Alternative way for displaying help menu of patch flow
Date: Fri, 28 Apr 2017 10:44:22 +0530	[thread overview]
Message-ID: <b55bd985-be6a-7fd6-1744-7ffb9d8b4ce8@gmail.com> (raw)

Hello community,

I would like to state about a small issue I face when I use the `git add 
-i` command. I guess it's expressed easily with an example.

**** Start ****

Imagine a situation in which you accidentally made a reasonable amount 
of change to your code from your last commit. You would like to put them 
in separate commits and hence you go for the `git add -i` command and 
choose the `patch` option. You choose the file which you want to update 
as patches.

Unfortunately a hunk (of reasonable size) in the file seems to be having 
changes that you would like to be in separate commits. So, you would 
like to split the hunk into smaller parts but you forgot the correct 
option for it and you use `?` option. In most cases you wouldn't see the 
help menu completely. Moreover, if the hunk's size is reasonable enough 
to take up the whole screen of the terminal you would be seeing the same 
screen as before as the help menu is hidden above the hunk and you need 
to scroll to see it (only if you knew it's up there in the first place!)

**** End ****

I guess it would be better to display the help menu in a separate flow, 
like when the user click the `?` option in the `patch` flow then the 
whole screen is cleared and the help menu is displayed in some 
appropriate place and after the user has viewed the help menu he could 
quit from the help screen (probably by using a key like `q`) to continue 
where he left off. I think it would be better because, in general, a 
user would want to see the help menu when he uses the `?` option in the 
patch flow, not the hunk that gets displayed after it.

Is it a good suggestion or is there anything I missed?

Quote : "You don’t change the world by doing what you’re told.” — Joi Ito

Regards,
Kaartic


             reply	other threads:[~2017-04-28  5:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28  5:14 Kaartic Sivaraam [this message]
2017-04-28  6:37 ` [Suggestion] Alternative way for displaying help menu of patch flow Jeff King
2017-04-28  7:21   ` Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b55bd985-be6a-7fd6-1744-7ffb9d8b4ce8@gmail.com \
    --to=kaarticsivaraam91196@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).