From: Karthik Nayak <karthik.188@gmail.com>
To: karthik.188@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, jltobler@gmail.com,
toon@iotcl.com
Subject: [PATCH v2 2/3] clang-format: don't align expressions after linebreaks
Date: Thu, 10 Oct 2024 19:59:10 +0200 [thread overview]
Message-ID: <b55d5d2c14142fddad0b5bb84f41dd1c4eb6397a.1728582927.git.karthik.188@gmail.com> (raw)
In-Reply-To: <cover.1728582927.git.karthik.188@gmail.com>
We enforce alignment of expressions after linebreaks. Which means for
code such as
return a || b;
it will expect:
return a ||
b;
we instead want 'b' to be indent with tabs, which is already done by the
'ContinuationIndentWidth' variable. So let's explicitly set
'AlignOperands' to false.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
.clang-format | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/.clang-format b/.clang-format
index 684ab32d28..d655b08ff6 100644
--- a/.clang-format
+++ b/.clang-format
@@ -42,10 +42,9 @@ AlignConsecutiveDeclarations: false
# int cccccccc;
AlignEscapedNewlines: Left
-# Align operands of binary and ternary expressions
-# int aaa = bbbbbbbbbbb +
-# cccccc;
-AlignOperands: true
+# Don't enforce alignment after linebreaks and instead
+# rely on the ContinuationIndentWidth value.
+AlignOperands: false
# Don't align trailing comments
# int a; // Comment a
--
2.47.0
next prev parent reply other threads:[~2024-10-10 17:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 12:51 [PATCH 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-09 12:55 ` [PATCH 1/3] clang-format: don't enforce the column limit Karthik Nayak
2024-10-09 15:45 ` Justin Tobler
2024-10-09 22:32 ` Junio C Hamano
2024-10-10 16:48 ` karthik nayak
2024-10-09 12:56 ` [PATCH 2/3] clang-format: don't align expressions after linebreaks Karthik Nayak
2024-10-09 12:56 ` [PATCH 3/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-10 8:27 ` Toon Claes
2024-10-10 17:59 ` [PATCH v2 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-10 17:59 ` [PATCH v2 1/3] clang-format: change column limit to 96 characters Karthik Nayak
2024-10-10 18:11 ` Kyle Lippincott
2024-10-10 19:49 ` karthik nayak
2024-10-10 20:09 ` Kyle Lippincott
2024-10-10 17:59 ` Karthik Nayak [this message]
2024-10-10 17:59 ` [PATCH v2 3/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-12 1:49 ` [PATCH v3 0/3] clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-12 1:49 ` [PATCH v3 1/3] clang-format: re-adjust line break penalties Karthik Nayak
2024-10-14 9:08 ` Toon Claes
2024-10-14 21:14 ` Taylor Blau
2024-10-15 11:35 ` karthik nayak
2024-10-15 11:20 ` karthik nayak
2024-10-14 20:59 ` Kyle Lippincott
2024-10-15 12:37 ` karthik nayak
2024-10-16 1:38 ` Kyle Lippincott
2024-10-16 21:17 ` karthik nayak
2024-10-12 1:49 ` [PATCH v3 2/3] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-14 21:12 ` Kyle Lippincott
2024-10-15 7:57 ` karthik nayak
2024-10-12 1:49 ` [PATCH v3 3/3] clang-format: don't align expressions after linebreaks Karthik Nayak
2024-10-14 21:23 ` Kyle Lippincott
2024-10-15 11:17 ` karthik nayak
2024-10-18 8:46 ` [PATCH v4 0/2] Subject: clang-format: fix rules to make the CI job cleaner Karthik Nayak
2024-10-18 8:46 ` [PATCH v4 1/2] clang-format: re-adjust line break penalties Karthik Nayak
2024-10-25 2:37 ` Justin Tobler
2024-10-25 9:48 ` karthik nayak
2024-10-18 8:46 ` [PATCH v4 2/2] clang-format: align consecutive macro definitions Karthik Nayak
2024-10-18 21:37 ` [PATCH v4 0/2] Subject: clang-format: fix rules to make the CI job cleaner Taylor Blau
2024-10-20 11:17 ` karthik nayak
2024-10-21 21:48 ` Taylor Blau
2024-10-22 8:31 ` karthik nayak
2024-10-22 16:42 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b55d5d2c14142fddad0b5bb84f41dd1c4eb6397a.1728582927.git.karthik.188@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).