From: "Deepak Barua" <dbbarua@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: Adding spell checker to GIT
Date: Sat, 6 Jan 2007 08:51:56 +0530 [thread overview]
Message-ID: <b5a19cd20701051921j69f1a85bo97e39db7d8401222@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0701052147070.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Hi Johannes,
I spell check "//" comments in
in find_ext()
if($_[0] =~ /\.cc|\.java/) {
$start_pattern = qr!\s/\*\s|\s//\s!;
}
and
$chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End
Pattern Not Found" ;
Also yes i didnt include to use spell checking in string literals , i
thought that would be irregular and cumbersome.
Could you please test the code then i can include it in a seperate file ..?
Regards
Deepak
On 1/6/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Fri, 5 Jan 2007, Deepak Barua wrote:
>
> > I and sasikumar have designed and built a spell checker into
> > the pre-commit hook, could someone please test it and give us your
> > comments.
>
> It's a rather big chunk of code, and it is in perl, so I'd rather put it
> in another file, but oh well.
>
> There are a few remaining problems, and I don't even know if the second
> can be solved:
>
> - you miss "//" comments,
> - if the diff is only about a small part of a comment, you do not spell
> check that
> - you do not spell check literal messages (i.e. printf("No such fiel!"))
>
> Ciao,
> Dscho
>
>
--
Code Code Code Away
next prev parent reply other threads:[~2007-01-06 3:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 20:46 Adding spell checker to GIT Deepak Barua
2007-01-05 20:49 ` Johannes Schindelin
2007-01-06 3:21 ` Deepak Barua [this message]
2007-01-16 16:10 ` Johannes Schindelin
2007-01-16 17:34 ` Deepak Barua
2007-01-25 14:36 ` Deepak Barua
2007-01-25 16:46 ` Johannes Schindelin
2007-01-26 7:22 ` Deepak Barua
-- strict thread matches above, loose matches on Subject: below --
2006-12-26 12:02 Deepak Barua
2006-12-05 16:05 Deepak Barua
2006-12-05 16:12 ` Jakub Narebski
2006-12-05 16:13 ` Johannes Schindelin
2006-12-05 16:39 ` Deepak Barua
2006-12-05 17:08 ` Andreas Ericsson
[not found] ` <200612051726.kB5HQO2t015777@laptop13.inf.utfsm.cl>
2006-12-12 19:51 ` Deepak Barua
2006-12-12 20:27 ` Johannes Schindelin
[not found] ` <d22d265a0612130103o1efcbd87sb93be9c2dad71307@mail.gmail.com>
2006-12-13 10:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a19cd20701051921j69f1a85bo97e39db7d8401222@mail.gmail.com \
--to=dbbarua@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).