git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Chris Larson" <clarson@kergoth.com>
To: git@vger.kernel.org
Subject: [PATCH] git-submodule fixes for call to git config --get-regexp
Date: Fri, 20 Jul 2007 10:23:05 -0700	[thread overview]
Message-ID: <b6ebd0a50707201023h12ed3c61v31ccb2b356c1ee42@mail.gmail.com> (raw)

Two minor git-submodule fixes:
* Escape !'s in the git config --get-regexp, so submodule paths can
contain them.
* Be more explicit about the value regex, otherwise things get confused if one
  submodule name is a prefix of another (since --get-regexp can return
  multiple values).

Signed-off-by: Chris Larson <clarson@kergoth.com>

--- git-submodule.sh.old	2007-07-20 10:13:22.578125000 -0700
+++ git-submodule.sh	2007-07-20 10:14:56.281250000 -0700
@@ -46,7 +46,8 @@ get_repo_base() {
 #
 module_name()
 {
-       name=$(GIT_CONFIG=.gitmodules git config --get-regexp
'^submodule\..*\.path$' "$1" |
+       path=$(echo "$1" | sed -e 's/\!/\\!/g')
+       name=$(GIT_CONFIG=.gitmodules git config --get-regexp
'^submodule\..*\.path$' "^$path$" |
        sed -nre 's/^submodule\.(.+)\.path .+$/\1/p')
        test -z "$name" &&
        die "No submodule mapping found in .gitmodules for path '$path'"

-- 
Chris Larson - clarson at kergoth dot com
Dedicated Engineer - MontaVista - clarson at mvista dot com
Core Developer/Architect - TSLib, BitBake, OpenEmbedded, OpenZaurus

         reply	other threads:[~2007-07-20 17:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-28 20:51 [PATCH] Let .git/config specify the url for submodules Lars Hjemli
2007-05-31  0:17 ` Lars Hjemli
2007-05-31 23:43   ` Junio C Hamano
2007-06-01  8:08   ` Josef Weidendorfer
2007-06-01  9:17     ` Lars Hjemli
2007-06-01  8:57   ` Sven Verdoolaege
2007-06-01  9:25     ` Lars Hjemli
2007-06-01  9:35       ` Sven Verdoolaege
2007-06-01 14:45         ` Lars Hjemli
2007-06-01 14:51           ` Sven Verdoolaege
2007-06-01 15:56             ` Lars Hjemli
2007-06-01 16:29               ` Linus Torvalds
2007-06-01 19:55                 ` Junio C Hamano
2007-06-02  7:13                   ` Lars Hjemli
2007-06-02  7:44                     ` Sven Verdoolaege
2007-06-02  8:39                       ` Lars Hjemli
2007-06-02  9:15                         ` Junio C Hamano
2007-06-02  9:53                           ` Lars Hjemli
2007-06-02 10:12                             ` Junio C Hamano
2007-06-02 10:38                               ` Lars Hjemli
2007-07-20 17:23                       ` Chris Larson [this message]
2007-07-20 18:07                         ` [PATCH] git-submodule fixes for call to git config --get-regexp Junio C Hamano
2007-07-20 18:36                           ` Johannes Schindelin
2007-07-25  0:09                             ` submodule init problem Ricky Nite
2007-07-25  0:30                               ` Ricky Nite
2007-07-25  1:49                                 ` Junio C Hamano
2007-07-25  8:15                                   ` Sven Verdoolaege
2007-07-25 20:25                                     ` Lars Hjemli
2007-07-25 20:31                                       ` Johannes Schindelin
2007-07-25 20:40                                         ` Lars Hjemli
2007-07-25 20:50                                           ` Johannes Schindelin
2007-07-25 22:20                                     ` Junio C Hamano
2007-07-25 23:43                                       ` Ricky Nite
2007-07-25 23:49                                         ` Junio C Hamano
2007-06-02  7:49                 ` [PATCH] Let .git/config specify the url for submodules Sven Verdoolaege
2007-06-02 16:34                   ` Linus Torvalds
2007-06-02 17:35                     ` Sven Verdoolaege

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6ebd0a50707201023h12ed3c61v31ccb2b356c1ee42@mail.gmail.com \
    --to=clarson@kergoth.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).