Git development
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v3 0/4] pack-objects: support bitmaps and delta-islands with `--path-walk`
Date: Mon, 22 Jun 2026 09:36:02 -0400	[thread overview]
Message-ID: <b6ed816c-030b-400a-9fb6-6671fd3cb0b0@gmail.com> (raw)
In-Reply-To: <xmqqmrwn3u4x.fsf@gitster.g>

On 6/22/2026 3:35 AM, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:

>> Outside of the above, the series is functionally unchanged.
>>
>> Thanks in advance for another look.
>>
>> Taylor Blau (4):
>>   t/perf: drop p5311's lookup-table permutation
>>   pack-objects: support reachability bitmaps with `--path-walk`
>>   pack-objects: extract `record_tree_depth()` helper
>>   pack-objects: support `--delta-islands` with `--path-walk`
> 
> Very cleanly implemented.  I am not confident that I have followed
> the detailed logic around delta islands in the last step but the
> earlier three patches looked trivially good.
I've been happy with the code, subject to the new data that is presented
with this version confirming the expected performance benefits. I also
lack confidence in the delta islands features, but based on my weak
understanding it looks correct. I believe that Taylor has the right
expertise here to make up for my lack of context.

Thanks,
-Stolee

  reply	other threads:[~2026-06-22 13:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 23:18 [PATCH 0/3] pack-objects: support bitmaps and delta-islands with `--path-walk` Taylor Blau
2026-05-27 23:18 ` [PATCH 1/3] pack-objects: support reachability bitmaps " Taylor Blau
2026-05-27 23:18 ` [PATCH 2/3] pack-objects: extract `record_tree_depth()` helper Taylor Blau
2026-05-27 23:18 ` [PATCH 3/3] pack-objects: support `--delta-islands` with `--path-walk` Taylor Blau
2026-05-28 15:28 ` [PATCH 0/3] pack-objects: support bitmaps and delta-islands " Derrick Stolee
2026-05-29 17:26   ` Derrick Stolee
2026-05-29 20:07     ` Taylor Blau
2026-05-29 21:28       ` Derrick Stolee
2026-05-29 22:20         ` Taylor Blau
2026-06-02 22:21 ` [PATCH v2 0/4] " Taylor Blau
2026-06-02 22:21   ` [PATCH v2 1/4] t/perf: drop p5311's lookup-table permutation Taylor Blau
2026-06-02 22:21   ` [PATCH v2 2/4] pack-objects: support reachability bitmaps with `--path-walk` Taylor Blau
2026-06-12 13:03     ` Derrick Stolee
2026-06-19 14:16       ` Taylor Blau
2026-06-19 14:36         ` Derrick Stolee
2026-06-19 14:46           ` Taylor Blau
2026-06-12 13:24     ` Derrick Stolee
2026-06-19 14:28       ` Taylor Blau
2026-06-19 14:40         ` Derrick Stolee
2026-06-19 14:52           ` Taylor Blau
2026-06-19 15:33             ` Derrick Stolee
2026-06-15 20:57     ` Junio C Hamano
2026-06-19 14:08       ` Taylor Blau
2026-06-02 22:21   ` [PATCH v2 3/4] pack-objects: extract `record_tree_depth()` helper Taylor Blau
2026-06-02 22:21   ` [PATCH v2 4/4] pack-objects: support `--delta-islands` with `--path-walk` Taylor Blau
2026-06-21 23:02 ` [PATCH v3 0/4] pack-objects: support bitmaps and delta-islands " Taylor Blau
2026-06-21 23:02   ` [PATCH v3 1/4] t/perf: drop p5311's lookup-table permutation Taylor Blau
2026-06-21 23:03   ` [PATCH v3 2/4] pack-objects: support reachability bitmaps with `--path-walk` Taylor Blau
2026-06-21 23:03   ` [PATCH v3 3/4] pack-objects: extract `record_tree_depth()` helper Taylor Blau
2026-06-21 23:03   ` [PATCH v3 4/4] pack-objects: support `--delta-islands` with `--path-walk` Taylor Blau
2026-06-22  7:35   ` [PATCH v3 0/4] pack-objects: support bitmaps and delta-islands " Junio C Hamano
2026-06-22 13:36     ` Derrick Stolee [this message]
2026-06-22 16:26       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6ed816c-030b-400a-9fb6-6671fd3cb0b0@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox