Test suite failures due to Error.pm issues.

Test suite failures due to Error.pm issues.

[carbonated beverage]

Hi all,

I was trying to track down the cause of massive test failures in make
test, and running the failing entries via -v showed the following popping
up over and over again:

Can't locate Error.pm in @INC (@INC contains: /home/ramune/src/git/git/t/../perl/blib/lib /home/ramune/src/git/git/t/../perl/blib/arch/auto/Git /etc/perl /usr/local/lib/perl/5.8.8 /usr/local/share/perl/5.8.8
 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.8 /usr/share/perl/5.8 /usr/local/lib/site_perl .) at /home/ramune/src/git/git/t/../perl/blib/lib/Git.pm line 93.^
BEGIN failed--compilation aborted at /home/ramune/src/git/git/t/../perl/blib/lib/Git.pm line 93.^
Compilation failed in require at /home/ramune/src/git/git/t/../git-add--interactive line 5.^
BEGIN failed--compilation aborted at /home/ramune/src/git/git/t/../git-add--interactive line 5.^

Since git has private-Error.pm file, shouldn't that be picked up by the
make test invocation?

-- DN
Daniel

Re: Test suite failures due to Error.pm issues.

[Rafael Garcia-Suarez]

On 09/04/2008, carbonated beverage <ramune@net-ronin.org> wrote:
> Hi all,
>
>  I was trying to track down the cause of massive test failures in make
>  test, and running the failing entries via -v showed the following popping
>  up over and over again:
>
>  Can't locate Error.pm in @INC (@INC contains: /home/ramune/src/git/git/t/../perl/blib/lib /home/ramune/src/git/git/t/../perl/blib/arch/auto/Git /etc/perl /usr/local/lib/perl/5.8.8 /usr/local/share/perl/5.8.8
>   /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.8 /usr/share/perl/5.8 /usr/local/lib/site_perl .) at /home/ramune/src/git/git/t/../perl/blib/lib/Git.pm line 93.^
>  BEGIN failed--compilation aborted at /home/ramune/src/git/git/t/../perl/blib/lib/Git.pm line 93.^
>  Compilation failed in require at /home/ramune/src/git/git/t/../git-add--interactive line 5.^
>  BEGIN failed--compilation aborted at /home/ramune/src/git/git/t/../git-add--interactive line 5.^
>
>  Since git has private-Error.pm file, shouldn't that be picked up by the
>  make test invocation?

The private Error file is not installed if perl/Makefile.PL detects
than an Error.pm recent enough on your system. Do you actually have
perl/blib/lib/Error.pm ? Try to run (cd perl; make clean; cd ..; make)
and try the tests again.

Re: Test suite failures due to Error.pm issues.

[carbonated beverage]

(Was on the road for work, so couldn't reply till now)

> The private Error file is not installed if perl/Makefile.PL detects
> than an Error.pm recent enough on your system. Do you actually have
> perl/blib/lib/Error.pm ? Try to run (cd perl; make clean; cd ..; make)
> and try the tests again.

ramune/lycaeum:git: locate Error.pm
/usr/local/stow/git-1.5.4.5/share/perl/5.8.8/Error.pm
/usr/share/perl5/Debconf/Element/Dialog/Error.pm
/usr/share/perl5/Debconf/Element/Editor/Error.pm
/usr/share/perl5/Debconf/Element/Gnome/Error.pm
/usr/share/perl5/Debconf/Element/Kde/Error.pm
/usr/share/perl5/Debconf/Element/Noninteractive/Error.pm
/usr/share/perl5/Debconf/Element/Teletype/Error.pm
/usr/share/perl5/Debconf/Element/Web/Error.pm
ramune/lycaeum:git: 

So... there's Error.pm files around, but I remember now having to copy it
over for previous versions of git.  Reporting it slipped my mind until now
(sorry).

After the:
 cd perl
 make clean
 cd ..
 make -j4
 make test

when git 1.5.4.5 is still in /usr/local/stow/git-1.5.4.5 and stow'd to
/usr/local, it passes.  So it looks like it was picking up the previous
Error.pm installed in the git directory from the previous installation.

So when it was stow -D'd, and the new git installed and stow'd, the Error.pm
went away (also, when the old git was stow -D'd before running the test).

Not sure what the right way to handle this is.  I may just make a note to
always copy over Error.pm, if it won't change in the git source.

-- DN
Daniel