From: "Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: "Michael Hendricks" <michael@ndrix.org>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Remove dependency on IO::String from Git.pm test
Date: Wed, 18 Jun 2008 17:10:57 +0200 [thread overview]
Message-ID: <b77c1dce0806180810r46a3e2a5i4eb228e6dc19613d@mail.gmail.com> (raw)
In-Reply-To: <m37icmol6y.fsf@localhost.localdomain>
2008/6/18 Jakub Narebski <jnareb@gmail.com>:
> Michael Hendricks <michael@ndrix.org> writes:
>
>> Instead of using IO::String to create an in-memory filehandle, use
>> open() with a scalar reference as the filename. This feature has been
>> available since Perl 5.8.0 (which was released in 2002), so it should
>> be available pretty much everywhere by now.
>
> Besides if I understand correctly gitweb very much requires Perl >= 5.8
> because of required Unicode support.
>
> Nevertheless adding "use v5.8.0;" or "use 5.008_000;" would be I guess
> good idea.
"use 5.008;" is preferred form; "use v5.8.0" might yield obscure error
messages on perls < 5.6, which is not the desired result.
next prev parent reply other threads:[~2008-06-18 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 13:37 [PATCH] Remove dependency on IO::String from Git.pm test Michael Hendricks
2008-06-18 14:46 ` Jakub Narebski
2008-06-18 15:10 ` Rafael Garcia-Suarez [this message]
2008-06-18 17:00 ` Johannes Schindelin
2008-06-18 17:52 ` Jakub Narebski
2008-06-18 19:35 ` Johannes Schindelin
2008-06-18 19:42 ` Lea Wiemann
2008-06-18 19:13 ` Junio C Hamano
2008-06-18 19:37 ` Johannes Schindelin
2008-06-19 18:25 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b77c1dce0806180810r46a3e2a5i4eb228e6dc19613d@mail.gmail.com \
--to=rgarciasuarez@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=michael@ndrix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).