From: Derrick Stolee <stolee@gmail.com>
To: Matthew John Cheetham <mjcheetham@outlook.com>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: gitster@pobox.com, ps@pks.im
Subject: Re: [PATCH v5 0/8] fetch: rework negotiation tip options
Date: Tue, 19 May 2026 11:08:05 -0400 [thread overview]
Message-ID: <b78904f6-5465-4dcf-bf6a-629f925ce1b2@gmail.com> (raw)
In-Reply-To: <VI0PR03MB11634DBCD7ED97E3358AC9339C0002@VI0PR03MB11634.eurprd03.prod.outlook.com>
On 5/19/2026 5:13 AM, Matthew John Cheetham wrote:
> On 2026-05-18 21:19, Derrick Stolee via GitGitGadget wrote:
>
>> Range-diff vs v4:
>>
>> 1: 7409a479d6 ! 1: 538913a327 t5516: fix test order flakiness
>> @@ Commit message
>> Use 'sort -k 3' to match the actual number of columns in the output.
>> + Reviewed-by: Matthew John Cheetham <mcheetham@outlook.com>
>> Signed-off-by: Derrick Stolee <stolee@gmail.com>
>
> mjcheetham@outlook.com, not mcheetham@outlook.com.
OH NO! Sorry for this typo that I copied into every commit.
> LGTM
>
> Thanks,
> Matthew
I'll fix this reviewed-by tag and resend. Sorry :(
Thanks for the review!
next prev parent reply other threads:[~2026-05-19 15:08 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 14:36 [PATCH 0/4] fetch: add --must-have and remote.*.mustHave Derrick Stolee via GitGitGadget
2026-04-08 14:36 ` [PATCH 1/4] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-04-08 14:36 ` [PATCH 2/4] fetch: add --must-have option for negotiation Derrick Stolee via GitGitGadget
2026-04-08 14:36 ` [PATCH 3/4] remote: add mustHave config as default for --must-have Derrick Stolee via GitGitGadget
2026-04-08 14:36 ` [PATCH 4/4] send-pack: pass --must-have for push negotiation Derrick Stolee via GitGitGadget
2026-04-08 18:59 ` [PATCH 0/4] fetch: add --must-have and remote.*.mustHave Junio C Hamano
2026-04-09 12:53 ` Derrick Stolee
2026-04-15 15:14 ` [PATCH v2 0/7] fetch: rework negotiation tip options Derrick Stolee via GitGitGadget
2026-04-15 15:14 ` [PATCH v2 1/7] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-04-15 15:14 ` [PATCH v2 2/7] fetch: add --negotiation-restrict option Derrick Stolee via GitGitGadget
2026-04-15 21:57 ` Junio C Hamano
2026-04-19 23:00 ` Derrick Stolee
2026-04-20 10:32 ` Junio C Hamano
2026-04-20 11:35 ` Derrick Stolee
2026-04-15 15:14 ` [PATCH v2 3/7] transport: rename negotiation_tips Derrick Stolee via GitGitGadget
2026-04-20 8:11 ` Patrick Steinhardt
2026-04-15 15:14 ` [PATCH v2 4/7] remote: add remote.*.negotiationRestrict config Derrick Stolee via GitGitGadget
2026-04-15 19:16 ` Junio C Hamano
2026-04-15 15:14 ` [PATCH v2 5/7] fetch: add --negotiation-require option for negotiation Derrick Stolee via GitGitGadget
2026-04-15 19:50 ` Junio C Hamano
2026-04-21 18:06 ` Derrick Stolee
2026-04-20 8:11 ` Patrick Steinhardt
2026-04-20 11:41 ` Derrick Stolee
2026-04-15 15:14 ` [PATCH v2 6/7] remote: add negotiationRequire config as default for --negotiation-require Derrick Stolee via GitGitGadget
2026-04-15 15:14 ` [PATCH v2 7/7] send-pack: pass negotiation config in push Derrick Stolee via GitGitGadget
2026-04-22 15:25 ` [PATCH v3 0/7] fetch: rework negotiation tip options Derrick Stolee via GitGitGadget
2026-04-22 15:25 ` [PATCH v3 1/7] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-05-12 10:50 ` Matthew John Cheetham
2026-04-22 15:25 ` [PATCH v3 2/7] fetch: add --negotiation-restrict option Derrick Stolee via GitGitGadget
2026-05-12 11:11 ` Matthew John Cheetham
2026-05-12 14:23 ` Derrick Stolee
2026-04-22 15:25 ` [PATCH v3 3/7] transport: rename negotiation_tips Derrick Stolee via GitGitGadget
2026-05-12 11:30 ` Matthew John Cheetham
2026-05-12 14:33 ` Derrick Stolee
2026-04-22 15:25 ` [PATCH v3 4/7] remote: add remote.*.negotiationRestrict config Derrick Stolee via GitGitGadget
2026-05-12 12:29 ` Matthew John Cheetham
2026-05-12 14:52 ` Derrick Stolee
2026-04-22 15:25 ` [PATCH v3 5/7] fetch: add --negotiation-include option for negotiation Derrick Stolee via GitGitGadget
2026-05-12 14:38 ` Matthew John Cheetham
2026-05-12 16:54 ` Derrick Stolee
2026-04-22 15:25 ` [PATCH v3 6/7] remote: add remote.*.negotiationInclude config Derrick Stolee via GitGitGadget
2026-05-12 14:54 ` Matthew John Cheetham
2026-05-12 17:55 ` Derrick Stolee
2026-04-22 15:25 ` [PATCH v3 7/7] send-pack: pass negotiation config in push Derrick Stolee via GitGitGadget
2026-05-12 15:14 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 0/8] fetch: rework negotiation tip options Derrick Stolee via GitGitGadget
2026-05-14 12:41 ` [PATCH v4 1/8] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-05-18 16:19 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 2/8] fetch: add --negotiation-restrict option Derrick Stolee via GitGitGadget
2026-05-18 16:37 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 3/8] transport: rename negotiation_tips Derrick Stolee via GitGitGadget
2026-05-18 16:42 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 4/8] remote: add remote.*.negotiationRestrict config Derrick Stolee via GitGitGadget
2026-05-18 16:46 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 5/8] negotiator: add have_sent() interface Derrick Stolee via GitGitGadget
2026-05-18 16:57 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 6/8] fetch: add --negotiation-include option for negotiation Derrick Stolee via GitGitGadget
2026-05-18 17:12 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 7/8] remote: add remote.*.negotiationInclude config Derrick Stolee via GitGitGadget
2026-05-18 17:18 ` Matthew John Cheetham
2026-05-14 12:41 ` [PATCH v4 8/8] send-pack: pass negotiation config in push Derrick Stolee via GitGitGadget
2026-05-18 17:21 ` Matthew John Cheetham
2026-05-18 17:24 ` [PATCH v4 0/8] fetch: rework negotiation tip options Matthew John Cheetham
2026-05-18 19:27 ` Derrick Stolee
2026-05-18 20:19 ` [PATCH v5 " Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 1/8] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 2/8] fetch: add --negotiation-restrict option Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 3/8] transport: rename negotiation_tips Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 4/8] remote: add remote.*.negotiationRestrict config Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 5/8] negotiator: add have_sent() interface Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 6/8] fetch: add --negotiation-include option for negotiation Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 7/8] remote: add remote.*.negotiationInclude config Derrick Stolee via GitGitGadget
2026-05-18 20:19 ` [PATCH v5 8/8] send-pack: pass negotiation config in push Derrick Stolee via GitGitGadget
2026-05-19 9:13 ` [PATCH v5 0/8] fetch: rework negotiation tip options Matthew John Cheetham
2026-05-19 15:08 ` Derrick Stolee [this message]
2026-05-19 16:24 ` [PATCH v6 " Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 1/8] t5516: fix test order flakiness Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 2/8] fetch: add --negotiation-restrict option Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 3/8] transport: rename negotiation_tips Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 4/8] remote: add remote.*.negotiationRestrict config Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 5/8] negotiator: add have_sent() interface Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 6/8] fetch: add --negotiation-include option for negotiation Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 7/8] remote: add remote.*.negotiationInclude config Derrick Stolee via GitGitGadget
2026-05-19 16:24 ` [PATCH v6 8/8] send-pack: pass negotiation config in push Derrick Stolee via GitGitGadget
2026-05-19 16:48 ` [PATCH v6 0/8] fetch: rework negotiation tip options Matthew John Cheetham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b78904f6-5465-4dcf-bf6a-629f925ce1b2@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=mjcheetham@outlook.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox