From: Karl Wiberg <kha@treskal.com>
To: Alex Chiang <achiang@hp.com>
Cc: catalin.marinas@gmail.com, git@vger.kernel.org
Subject: Re: [StGit RFC PATCH 0/6] add support for git send-email
Date: Tue, 1 Dec 2009 08:38:19 +0100 [thread overview]
Message-ID: <b8197bcb0911302338x39f06c1du2023d76c9f094121@mail.gmail.com> (raw)
In-Reply-To: <20091201000258.GM12733@ldl.fc.hp.com>
On Tue, Dec 1, 2009 at 1:02 AM, Alex Chiang <achiang@hp.com> wrote:
> * Karl Wiberg <kha@treskal.com>:
>
>> Did you remember to run the regression tests? It's very helpful when
>> reviewing to know that the regression suite passes at every point in
>> the series.
>
> Good idea. I've been running t/t1900-mail.sh at each stage
Perfect.
> since my changes seem rather localized to sending mail.
>
> Should I be running the entire suite?
Just running that single test should be sufficient in this case; as
you say, the changes are rather well contained.
Running the whole suite takes a few minutes, so it might be worth
doing once in a while.
--
Karl Wiberg, kha@treskal.com
subrabbit.wordpress.com
www.treskal.com/kalle
prev parent reply other threads:[~2009-12-01 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 19:50 [StGit RFC PATCH 0/6] add support for git send-email Alex Chiang
2009-11-28 19:50 ` [PATCH 1/6] stg mail: Refactor __send_message and friends Alex Chiang
2009-11-29 9:13 ` Karl Wiberg
2009-11-30 23:58 ` Alex Chiang
2009-11-28 19:50 ` [PATCH 2/6] stg mail: reorder __build_[message|cover] parameters Alex Chiang
2009-11-28 19:50 ` [PATCH 3/6] stg mail: make __send_message do more Alex Chiang
2009-11-29 21:23 ` Karl Wiberg
2009-11-30 23:59 ` Alex Chiang
2009-12-01 7:26 ` Karl Wiberg
2009-11-28 19:50 ` [PATCH 4/6] stg mail: factor out __update_header Alex Chiang
2009-11-28 19:50 ` [PATCH 5/6] stg mail: add basic support for git send-email Alex Chiang
2009-11-29 21:54 ` Karl Wiberg
2009-12-01 0:00 ` Alex Chiang
2009-12-01 7:33 ` Karl Wiberg
2009-11-28 19:50 ` [PATCH 6/6] stg mail: don't parse To/Cc/Bcc in --git mode Alex Chiang
2009-11-29 22:05 ` [StGit RFC PATCH 0/6] add support for git send-email Karl Wiberg
2009-12-01 0:02 ` Alex Chiang
2009-12-01 7:38 ` Karl Wiberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8197bcb0911302338x39f06c1du2023d76c9f094121@mail.gmail.com \
--to=kha@treskal.com \
--cc=achiang@hp.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).