From: Karl Wiberg <kha@treskal.com>
To: Alex Chiang <achiang@hp.com>
Cc: catalin.marinas@gmail.com, git <git@vger.kernel.org>
Subject: Re: [StGit PATCH v2 0/6] add support for git send-email
Date: Wed, 2 Dec 2009 07:46:02 +0100 [thread overview]
Message-ID: <b8197bcb0912012246n3b83866cjb93654effc000242@mail.gmail.com> (raw)
In-Reply-To: <20091202003503.7737.51579.stgit@bob.kio>
On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@hp.com> wrote:
> I also experimented with adding another test case for --git mode,
> basically duplicating t1900-mail.sh, and then adding the --git
> argument wherever it made sense.
Ah, good.
> However, that resulted in failure of the last 3 test cases, which is
> due to the fact that we no longer parse To/Cc/Bcc command line args
> in --git mode, and the resulting mbox file was missing the expected
> recipient addresses.
>
> I played around with that for a while, thinking that I could use git
> send-email --dry-run to do something equivalent, but then realized
> that git send-email's run-run mode is definitely not analogous to
> stg mail's --mbox mode.
>
> The upshot is that in stg mail, --git and --mbox don't interact
> well, and the resulting mbox file will lack the recipients. This
> might be fixed in the future if we teach git send-email how to
> generate mbox files, but then we introduce a versioning problem.
One wild idea: git send-email's --smtp-server flag will accept the
(full) path of a sendmail program; writing such a program, just
capable enough to receive the outgoing emails and dumping them to a
file, should be easy. Another option would be a program that speaks
just enough SMTP to accept the mails. (Incidentally, these two would
be useful in testing stg mail even without the --git option.)
I fully understand if you'd rather get on with scratching your actual
itch, though ...
> So let's just accept this wart for now, and say, if you want an mbox
> file generated, don't use --git. That seems reasonable to me.
Sure.
--
Karl Wiberg, kha@treskal.com
subrabbit.wordpress.com
www.treskal.com/kalle
next prev parent reply other threads:[~2009-12-02 6:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 0:46 [StGit PATCH v2 0/6] add support for git send-email Alex Chiang
2009-12-02 0:46 ` [StGit PATCH v2 1/6] stg mail: Refactor __send_message and friends Alex Chiang
2009-12-02 6:53 ` Karl Wiberg
2009-12-03 19:27 ` Alex Chiang
2009-12-03 20:46 ` [StGit PATCH v3 " Alex Chiang
2009-12-02 0:46 ` [StGit PATCH v2 2/6] stg mail: reorder __build_[message|cover] parameters Alex Chiang
2009-12-02 0:46 ` [StGit PATCH v2 3/6] stg mail: make __send_message do more Alex Chiang
2009-12-02 7:03 ` Karl Wiberg
2009-12-03 19:30 ` Alex Chiang
2009-12-04 7:00 ` Karl Wiberg
2009-12-02 0:46 ` [StGit PATCH v2 4/6] stg mail: factor out __update_header Alex Chiang
2009-12-02 0:46 ` [StGit PATCH v2 5/6] stg mail: add basic support for git send-email Alex Chiang
2009-12-02 0:46 ` [StGit PATCH v2 6/6] stg mail: don't parse To/Cc/Bcc in --git mode Alex Chiang
2009-12-02 6:46 ` Karl Wiberg [this message]
2009-12-03 19:27 ` [StGit PATCH v2 0/6] add support for git send-email Alex Chiang
2009-12-02 7:08 ` Karl Wiberg
2009-12-02 22:35 ` Catalin Marinas
2009-12-06 22:16 ` Catalin Marinas
2009-12-07 7:09 ` Karl Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8197bcb0912012246n3b83866cjb93654effc000242@mail.gmail.com \
--to=kha@treskal.com \
--cc=achiang@hp.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).