From: Karl Wiberg <kha@treskal.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 2/2] Pass the --in-reply-to and --no-thread options to git send-email
Date: Fri, 8 Jan 2010 07:43:44 +0100 [thread overview]
Message-ID: <b8197bcb1001072243h24e6248er79ac5a8afb6e3782@mail.gmail.com> (raw)
In-Reply-To: <20100107160937.3226.14811.stgit@pc1117.cambridge.arm.com>
On Thu, Jan 7, 2010 at 5:09 PM, Catalin Marinas <catalin.marinas@arm.com> wrote:
> + if options.in_reply_to:
> + cmd.append("--in-reply-to %s" % options.in_reply_to)
Have you tested this? I'm pretty sure you need "--in-reply-to=%s", or
to add the two strings separately---since as far as I can see, this
command is never shell-expanded.
--
Karl Wiberg, kha@treskal.com
subrabbit.wordpress.com
www.treskal.com/kalle
next prev parent reply other threads:[~2010-01-08 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 16:09 [StGit PATCH 1/2] Rename the mail --refid and --noreply options to match Git Catalin Marinas
2010-01-07 16:09 ` [StGit PATCH 2/2] Pass the --in-reply-to and --no-thread options to git send-email Catalin Marinas
2010-01-08 6:43 ` Karl Wiberg [this message]
2010-01-08 12:33 ` Catalin Marinas
2010-01-08 6:35 ` [StGit PATCH 1/2] Rename the mail --refid and --noreply options to match Git Karl Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8197bcb1001072243h24e6248er79ac5a8afb6e3782@mail.gmail.com \
--to=kha@treskal.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).