git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Wiberg <kha@treskal.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 1/3] Populate the cached config options with the  defaults
Date: Fri, 8 Jan 2010 15:30:48 +0100	[thread overview]
Message-ID: <b8197bcb1001080630i6daad79anf8323f8001d38db3@mail.gmail.com> (raw)
In-Reply-To: <20100108123559.24161.14842.stgit@pc1117.cambridge.arm.com>

Hmm. What's the point of this rewrite?

On Fri, Jan 8, 2010 at 1:35 PM, Catalin Marinas <catalin.marinas@arm.com> wrote:

> +        try:
> +            return self.__cache[name][-1]
> +        except KeyError:
> +            return None

You could write this as

  return self.__cache.get(name, [None])[-1]

-- 
Karl Wiberg, kha@treskal.com
   subrabbit.wordpress.com
   www.treskal.com/kalle

  reply	other threads:[~2010-01-08 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08 12:35 [StGit PATCH 0/3] Support for command aliases Catalin Marinas
2010-01-08 12:35 ` [StGit PATCH 1/3] Populate the cached config options with the defaults Catalin Marinas
2010-01-08 14:30   ` Karl Wiberg [this message]
2010-01-08 14:34     ` Karl Wiberg
2010-01-08 12:36 ` [StGit PATCH 2/3] Add support for command aliases Catalin Marinas
2010-01-08 12:36 ` [StGit PATCH 3/3] Replace some git commands with stg aliases in test scripts Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8197bcb1001080630i6daad79anf8323f8001d38db3@mail.gmail.com \
    --to=kha@treskal.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).