git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Goddard Rosa" <andre.goddard@gmail.com>
To: "Kevin Ballard" <kevin@sb.org>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Mike Ralphson" <mike.ralphson@gmail.com>,
	"Tim Harper" <timcharper@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] "not uptodate" changed to "has local changes"
Date: Sat, 17 May 2008 00:30:40 -0300	[thread overview]
Message-ID: <b8bf37780805162030m4c961505nabd72e8f5bd08404@mail.gmail.com> (raw)
In-Reply-To: <1ED37CF1-EABD-4881-BA29-ED2CB1CE73FC@sb.org>

On Fri, May 16, 2008 at 2:12 PM, Kevin Ballard <kevin@sb.org> wrote:
> On May 16, 2008, at 6:25 AM, Johannes Schindelin wrote:
>
>> On Thu, 15 May 2008, André Goddard Rosa wrote:
>>
>>>>> This patch will make git a little more human friendly, reporting
>>>>> "file.txt: has local changes".
>>>>
>>>> Documentation/git-checkout.txt should also change in this case,
>>>> otherwise users will see different output to that described and
>>>> possibly get confused if following along with the examples.
>>>>
>>>
>>> I like the idea too.
>>
>> No comment on the concern that it might break people's scripts?  None?
>
>
> How about an ugly hack? Look to see if stdout is a tty, if so spit out the
> more human-readable version, otherwise spit out the old version >:-)

Is this user interface set on stone? I think we should reserve the
right to improve always.

I would deprecate the current message, but I think that most users
cannot find so much of a sense in the former message,
although the script developer can easily change his scripts to search
for ´cannot merge´ instead.

Do you have a better idea?

---
[PATCH] "not uptodate" changed to "has local changes"

Use more straightforward message for regular user.

Signed-off-by: Andre Goddard Rosa <andre.goddard@gmail.com>

diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt
index a644173..624dea6 100644
--- a/Documentation/git-checkout.txt
+++ b/Documentation/git-checkout.txt
@@ -168,7 +168,7 @@ the above checkout would fail like this:
 +
 ------------
 $ git checkout mytopic
-fatal: Entry 'frotz' not uptodate. Cannot merge.
+fatal: Entry 'frotz' not uptodate, it has local changes. Cannot merge.
 ------------
 +
 You can give the `-m` flag to the command, which would try a

  reply	other threads:[~2008-05-17  3:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03 16:59 [PATCH] "not uptodate" changed to "has local changes" Tim Harper
2008-05-06 13:31 ` Mike Ralphson
2008-05-16  2:14   ` André Goddard Rosa
2008-05-16 10:25     ` Johannes Schindelin
2008-05-16 11:02       ` Holger Schurig
2008-05-16 11:50         ` Francis Moreau
2008-05-16 12:22         ` Johannes Schindelin
2008-05-16 17:12       ` Kevin Ballard
2008-05-17  3:30         ` André Goddard Rosa [this message]
2008-05-17 10:04           ` Johannes Schindelin
2008-05-17 14:44             ` Steven Walter
2008-05-17 16:12               ` Sverre Rabbelier
2008-05-17 18:44                 ` Johannes Schindelin
2008-05-17 20:14                   ` Sverre Rabbelier
     [not found]                     ` <200805181032.m4IAWjE0012832@mi0.bluebottle.com>
2008-05-18 11:11                       ` Sverre Rabbelier
2008-05-17 19:03                 ` Re* " Junio C Hamano
2008-05-17 20:29                   ` Sverre Rabbelier
2008-05-19  6:55                   ` Wincent Colaiuta
2008-05-19 17:47                     ` Junio C Hamano
2008-05-19 18:28                       ` Sverre Rabbelier
2008-05-19 19:32                       ` Daniel Barkalow
2008-05-21  7:07                         ` Junio C Hamano
2008-05-17 15:08             ` Wincent Colaiuta
2008-05-17 15:32               ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8bf37780805162030m4c961505nabd72e8f5bd08404@mail.gmail.com \
    --to=andre.goddard@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=kevin@sb.org \
    --cc=mike.ralphson@gmail.com \
    --cc=timcharper@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).