From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andr=E9_Goddard_Rosa?= Subject: Re: Problem with "From:" line on "git format-patch" generated patches Date: Wed, 4 Nov 2009 08:55:49 -0200 Message-ID: References: <20091103225556.GA20160@progeny.tock> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?ISO-8859-1?Q?Santi_B=E9jar?= , Git Mailing List To: Jonathan Nieder X-From: git-owner@vger.kernel.org Wed Nov 04 11:55:58 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5dWu-0006NZ-FC for gcvg-git-2@lo.gmane.org; Wed, 04 Nov 2009 11:55:56 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369AbZKDKzq convert rfc822-to-quoted-printable (ORCPT ); Wed, 4 Nov 2009 05:55:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755349AbZKDKzp (ORCPT ); Wed, 4 Nov 2009 05:55:45 -0500 Received: from mail-vw0-f192.google.com ([209.85.212.192]:34140 "EHLO mail-vw0-f192.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755348AbZKDKzo convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2009 05:55:44 -0500 Received: by vws30 with SMTP id 30so1899004vws.33 for ; Wed, 04 Nov 2009 02:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=8VvPGO6KUHd85uP8dfCdgigIl2lJMJ2KagojVnx5UK4=; b=dA07YVqkIsbv0Qqxi3sgzgjFKhsC9kYdYjUgup6Lu+74IBLhlKQyIqodfFFVnbdjqO FcQMTcyZviYZlMjW2R+m0c+zwj9DkuRDcHD9vglP58nZegb7NpuDtkCgCXNE4EdddhmU vh1jjd0WrwwoTT7pOJEW1TmObxqLJwgayFpbQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=XvMewe1+pu1o0j2E6wvCezNON49e5OgzDoBXDb1/s+WkOPlSyqC4eoTF//lYf85uSb hfb0IwdzuQXne8LhaJLAKMsecc+bSBJ8U7YyfTTYUUKdb7/pXmz6gX+dnTyr6z72h9GF L2RF32hYdm7v+HGGGDJZWgLfqkZ92stwTDGUs= Received: by 10.220.3.220 with SMTP id 28mr1378377vco.79.1257332149594; Wed, 04 Nov 2009 02:55:49 -0800 (PST) In-Reply-To: <20091103225556.GA20160@progeny.tock> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 11/3/09, Jonathan Nieder wrote: > Hi Andr=E9, > > Andr=E9 Goddard Rosa wrote: > >>> I'm not using any specific tool for inputting the git-format-patch, >>> but instead I'm sending the files generated by it through gmail as = an >>> inlined patch in the email body. >>> >>> I like the convenience of format-patch for generating the patch fil= es, >>> but in this case, formatting the header as rfc2047 is not necessary >>> and makes a funny/garbled output in my patch submission. > > The header fields git format-patch outputs are just intended as a > starting point for the header of your mailing. It is more convenient > to receive an e-mail with > > Delivered-to: maintainer@example.com > Received: [...] > Message-ID: > Date: Tue, 03 Nov 2009 16:33:54 -0600 > From: Patch Sender > Subject: [PATCH] Fix one bug, add another > Content-Type: text/plain; charset=3Dus-ascii > > Blah blah blah > > than one in which the content includes some useless metadata that was > already in the header. So you should just strip the header out from > the body before sending. > > There are three common exceptions: 1) you might want to send a patch > written by someone else, 2) you might want to mark a patch as written > before it was sent, and 3) some people like to receive patches as > attachments rather than inlined in messages. For the first two cases= , > the solution is to include the header fields to change in the body: > > From: Patch Writer > Date: Wed, 01 Apr 1970 01:23:45 +0100 > > Blah blah blah > --- > Hi, > > Patch Writer wrote this patch a while ago that might be > relevant. It needed a straightforward one-line change to > apply and is otherwise unchanged. > > What do you think? > [...] > > For the last case, I think it is most common to send unchanged 'git > format-patch' output. But only the From, Date, and Subject fields > are actually needed. > > I am not sure how well 'git am' copes with non-ascii characters in > the pseudo-header lines: I would have guessed it could handle them > both rfc2047-encoded and not, but I have not tried. > >> I really would like continuing having the convenience of using a web >> access to my gmail for sending the patches, so I just need a way to >> format the patches which makes it easy submitting them later. I'd li= ke >> to avoid using any other email client for that, if possible. > > Here, there is another danger: the Gmail web interface does not > consider your whitespace precious, so it is very prone to mangling > patches (especially with long lines). > > Documentation/SubmittingPatches [1] has some advice: > > | Gmail > | ----- > | > | GMail does not appear to have any way to turn off line wrapping in = the web > | interface, so this will mangle any emails that you send. You can h= owever > | use any IMAP email client to connect to the google imap server, and > forward > | the emails through that. Just make sure to disable line wrapping i= n that > | email client. Alternatively, use "git send-email" instead. > | > | Submitting properly formatted patches via Gmail is simple now that > | IMAP support is available. First, edit your ~/.gitconfig to specify= your > | account settings: > | > | [imap] > | folder =3D "[Gmail]/Drafts" > | host =3D imaps://imap.gmail.com > | user =3D user@gmail.com > | pass =3D p4ssw0rd > | port =3D 993 > | sslverify =3D false > | > | You might need to instead use: folder =3D "[Google Mail]/Drafts" if= you get > an error > | that the "Folder doesn't exist". > | > | Next, ensure that your Gmail settings are correct. In "Settings" th= e > | "Use Unicode (UTF-8) encoding for outgoing messages" should be chec= ked. > | > | Once your commits are ready to send to the mailing list, run the fo= llowing > | command to send the patch emails to your Gmail Drafts folder. > | > | $ git format-patch -M --stdout origin/master | git imap-send > | > | Go to your Gmail account, open the Drafts folder, find the patch em= ail, > fill > | in the To: and CC: fields and send away! > > Good luck. > > Hope that helps, Hello, Jonatan! Thanks for your insights, surely I understand what is reasoning be= hind it. I expect this thread will be useful to others in the future. Here goes another relevant reference about sending patches using web GUI of gmail : http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3D= blob;f=3DDocumentation/email-clients.txt;h=3Da618efab7b156658be70b29c1a= 6a9b9c4093e0f5;hb=3DHEAD Thanks a lot, Andr=E9