From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andr=E9_Goddard_Rosa?= Subject: Re: Problem with "From:" line on "git format-patch" generated patches Date: Wed, 4 Nov 2009 08:59:25 -0200 Message-ID: References: <20091104084903.GA1137@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?ISO-8859-1?Q?Santi_B=E9jar?= , Git Mailing List To: Jeff King X-From: git-owner@vger.kernel.org Wed Nov 04 11:59:34 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5daO-0007kd-OX for gcvg-git-2@lo.gmane.org; Wed, 04 Nov 2009 11:59:33 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755272AbZKDK7V convert rfc822-to-quoted-printable (ORCPT ); Wed, 4 Nov 2009 05:59:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754774AbZKDK7V (ORCPT ); Wed, 4 Nov 2009 05:59:21 -0500 Received: from mail-vw0-f192.google.com ([209.85.212.192]:60478 "EHLO mail-vw0-f192.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbZKDK7U convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2009 05:59:20 -0500 Received: by vws30 with SMTP id 30so1899653vws.33 for ; Wed, 04 Nov 2009 02:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=RFi4KXkpv4OMJWiFh4DQS0OVBjVBTdFXTYHZPEM/PR8=; b=F96zo0+fCX8/jPAglqJkO/LzU07qlhg22UC2HRRa+Xzz5Dit1cvgwZPFZMp/A0mpuR zc0lmM5bmB3U89iH4U1Nwl1jJdSdiWJMui83WdjMkBA9g09hWcHKY0Ol3pwPR0soMpFr at+lw5dEM3yF69HEnc2Gj9esxDAQB4wanELek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=wUPFCAjQ3AJ6VVLcWZDy5UrqHE3hM/8OH+8ub7LAejGD3iGj+SsR5nU/+BEjLWSAeU 7uv5hiwtlXHJe4hCR/b72TdcfniUzfHQ6K9+DouBhSM+Z/AugnPzr3tK+qg4/MNp6Jo8 XAIfsMosdqiS0oqHJ1Jb2FVjyopbiiwWvfbN0= Received: by 10.220.128.1 with SMTP id i1mr1345006vcs.87.1257332365531; Wed, 04 Nov 2009 02:59:25 -0800 (PST) In-Reply-To: <20091104084903.GA1137@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 11/4/09, Jeff King wrote: > On Tue, Nov 03, 2009 at 04:06:39PM -0200, Andr=E9 Goddard Rosa wrote: > >> I'm not using any specific tool for inputting the git-format-patch, >> but instead I'm sending the files generated by it through gmail as a= n >> inlined patch in the email body. >> >> I like the convenience of format-patch for generating the patch file= s, >> but in this case, formatting the header as rfc2047 is not necessary >> and makes a funny/garbled output in my patch submission. >> >> Do you have a suggestion for my workflow? > > I don't think there's currently a way to turn off the rfc2047 from > within format-patch. You can generate a single patch with the same > format using: > > git log -1 -p --stat --summary \ > --pretty=3Dtformat:'From: %an <%ae>%nDate: %aD%nSubject: [PATCH] = %s%n%n%b' > > but it won't do nice things like putting one patch in each file. > > Probably it would make sense for format-patch to have an option to > indicate that you are going to inline these patches into a different > MUA. So drop the 'From' mbox header line, don't rfc2047 encode, and > maybe some other behaviors. I do the same thing (including inline in > mutt), but I just delete the unwanted lines manually, and fortunately= my > name doesn't contain any non-ascii characters. ;) > > -Peff Hello, Peff! It's good to know that I'm not alone on this. I think that should be fairly easy, yes. Thanks for helping! Thank you all, Andr=E9