From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 3/4] load_revindex_from_disk(): avoid accessing uninitialized data
Date: Thu, 27 Mar 2025 12:43:48 +0000 [thread overview]
Message-ID: <b9901920de20ae29bd55bd68dab37a737867593b.1743079429.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1888.git.1743079429.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
The `revindex_size` value is uninitialized in case the function is
erroring out, but we want to assign its value. Let's just initialize it.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
pack-revindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pack-revindex.c b/pack-revindex.c
index d3832478d99..3b007d771b3 100644
--- a/pack-revindex.c
+++ b/pack-revindex.c
@@ -208,7 +208,7 @@ static int load_revindex_from_disk(char *revindex_name,
int fd, ret = 0;
struct stat st;
void *data = NULL;
- size_t revindex_size;
+ size_t revindex_size = 0;
struct revindex_header *hdr;
if (git_env_bool(GIT_TEST_REV_INDEX_DIE_ON_DISK, 0))
--
gitgitgadget
next prev parent reply other threads:[~2025-03-27 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 12:43 [PATCH 0/4] Initialize a few uninitialized variables Johannes Schindelin via GitGitGadget
2025-03-27 12:43 ` [PATCH 1/4] cat_one_file(): make it easy to see that the `size` variable is initialized Johannes Schindelin via GitGitGadget
2025-03-28 3:46 ` Jeff King
2025-03-27 12:43 ` [PATCH 2/4] fsck: avoid using an uninitialized variable Johannes Schindelin via GitGitGadget
2025-03-28 4:07 ` Jeff King
2025-03-27 12:43 ` Johannes Schindelin via GitGitGadget [this message]
2025-03-27 14:23 ` [PATCH 3/4] load_revindex_from_disk(): avoid accessing uninitialized data Taylor Blau
2025-03-27 12:43 ` [PATCH 4/4] load_pack_mtimes_file(): " Johannes Schindelin via GitGitGadget
2025-03-27 14:24 ` Taylor Blau
2025-07-17 16:45 ` [PATCH 0/4] Initialize a few uninitialized variables Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9901920de20ae29bd55bd68dab37a737867593b.1743079429.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).