From: Jiang Xin <worldhello.net@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Eric Sunshine <sunshine@sunshineco.com>,
Thomas Rast <trast@inf.ethz.ch>, Git List <git@vger.kernel.org>
Cc: Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH v4 3/3] Add colors to interactive git-clean
Date: Thu, 2 May 2013 21:15:04 +0800 [thread overview]
Message-ID: <bb5463fa4ef09df08ad3bf5abf4660a5df414e64.1367500374.git.worldhello.net@gmail.com> (raw)
In-Reply-To: <3b80db3d2e8f31b1d9373406cce3cbdee2094a29.1367500374.git.worldhello.net@gmail.com>
In-Reply-To: <vpq38u6n397.fsf@grenoble-inp.fr>
Show help, error messages, and prompt in colors for interactive
git-clean. Re-use config variables from git-add--interactive:
* color.interactive: When set to always, always use colors for
interactive prompts and displays. When false (or never),
never. When set to true or auto, use colors only when the
output is to the terminal.
* color.interactive.<slot>: Use customized color for interactive
git-clean output (like git add --interactive). <slot> may be
prompt, header, help or error.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
---
builtin/clean.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 70 insertions(+), 1 deletion(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index ac48e..c85b 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -14,6 +14,7 @@
#include "string-list.h"
#include "quote.h"
#include "column.h"
+#include "color.h"
static int force = -1; /* unset */
static int interactive;
@@ -30,15 +31,71 @@ static const char *msg_skip_git_dir = N_("Skipping repository %s\n");
static const char *msg_would_skip_git_dir = N_("Would skip repository %s\n");
static const char *msg_warn_remove_failed = N_("failed to remove %s");
+static int clean_use_color = -1;
+static char clean_colors[][COLOR_MAXLEN] = {
+ GIT_COLOR_RESET,
+ GIT_COLOR_NORMAL, /* PLAIN */
+ GIT_COLOR_BOLD_BLUE, /* PROMPT */
+ GIT_COLOR_BOLD_RED, /* HELP */
+ GIT_COLOR_BOLD_RED, /* ERROR */
+};
+enum color_clean {
+ CLEAN_COLOR_RESET = 0,
+ CLEAN_COLOR_PLAIN = 1,
+ CLEAN_COLOR_PROMPT = 2,
+ CLEAN_COLOR_HELP = 3,
+ CLEAN_COLOR_ERROR = 4
+};
+
+static int parse_clean_color_slot(const char *var, int ofs)
+{
+ if (!strcasecmp(var+ofs, "reset"))
+ return CLEAN_COLOR_RESET;
+ if (!strcasecmp(var+ofs, "plain"))
+ return CLEAN_COLOR_PLAIN;
+ if (!strcasecmp(var+ofs, "prompt"))
+ return CLEAN_COLOR_PROMPT;
+ if (!strcasecmp(var+ofs, "help"))
+ return CLEAN_COLOR_HELP;
+ if (!strcasecmp(var+ofs, "error"))
+ return CLEAN_COLOR_ERROR;
+ return -1;
+}
+
static int git_clean_config(const char *var, const char *value, void *cb)
{
if (!prefixcmp(var, "column."))
return git_column_config(var, value, "clean", &colopts);
+ if (!strcmp(var, "color.interactive")) {
+ clean_use_color = git_config_colorbool(var, value);
+ return 0;
+ }
+ if (!prefixcmp(var, "color.interactive.")) {
+ int slot = parse_clean_color_slot(var, 18);
+ if (slot < 0)
+ return 0;
+ if (!value)
+ return config_error_nonbool(var);
+ color_parse(value, var, clean_colors[slot]);
+ return 0;
+ }
if (!strcmp(var, "clean.requireforce")) {
force = !git_config_bool(var, value);
return 0;
}
- return git_default_config(var, value, cb);
+ return git_color_default_config(var, value, cb);
+}
+
+static const char *clean_get_color(enum color_clean ix)
+{
+ if (want_color(clean_use_color))
+ return clean_colors[ix];
+ return "";
+}
+
+static void clean_print_color(enum color_clean ix)
+{
+ printf("%s", clean_get_color(ix));
}
static int exclude_cb(const struct option *opt, const char *arg, int unset)
@@ -190,16 +247,20 @@ void interactive_clean_edit(struct string_list *dels, const char *prefix)
while (1) {
/* dels list may become empty when we run string_list_remove_empty_items later */
if (!dels->nr) {
+ clean_print_color(CLEAN_COLOR_ERROR);
printf_ln(_("No more files to clean, exiting."));
+ clean_print_color(CLEAN_COLOR_RESET);
break;
}
if (changed) {
+ clean_print_color(CLEAN_COLOR_HELP);
printf(_(
"NOTE: Will remove the following items. You can input space-seperated\n"
"NOTE: patterns (just like .gitignore) to exclude items from deletion,\n"
"NOTE: or press ENTER to continue."
));
+ clean_print_color(CLEAN_COLOR_RESET);
putchar('\n');
putchar('\n');
@@ -207,7 +268,9 @@ void interactive_clean_edit(struct string_list *dels, const char *prefix)
pretty_print_dels(dels, prefix);
}
+ clean_print_color(CLEAN_COLOR_PROMPT);
printf(_("Input ignore patterns> "));
+ clean_print_color(CLEAN_COLOR_RESET);
strbuf_getline(&confirm, stdin, '\n');
strbuf_trim(&confirm);
putchar('\n');
@@ -244,7 +307,9 @@ void interactive_clean_edit(struct string_list *dels, const char *prefix)
if (changed) {
string_list_remove_empty_items(dels, 0);
} else {
+ clean_print_color(CLEAN_COLOR_ERROR);
printf(_("WARNING: Cannot find items matched by: %s"), confirm.buf);
+ clean_print_color(CLEAN_COLOR_RESET);
putchar('\n');
}
@@ -263,6 +328,7 @@ void interactive_clean(struct string_list *dels, const char *prefix)
/* dels list may become empty after return back from edit mode */
while (dels->nr) {
+ clean_print_color(CLEAN_COLOR_HELP);
printf_ln(_(
"WARNING: The following items will be removed permanently. Press \"y\"\n"
"WARNING: to start cleaning, and press \"n\" to abort the cleaning.\n"
@@ -270,12 +336,15 @@ void interactive_clean(struct string_list *dels, const char *prefix)
"WARNING: to be excluded from the cleaning."
));
putchar('\n');
+ clean_print_color(CLEAN_COLOR_RESET);
/* Display dels in columns */
pretty_print_dels(dels, prefix);
/* Confirmation dialog */
+ clean_print_color(CLEAN_COLOR_PROMPT);
printf(count > 0 ? _("Remove (Yes/no/edit) ? ") : _("Remove (yes/no/Edit) ? "));
+ clean_print_color(CLEAN_COLOR_RESET);
strbuf_getline(&confirm, stdin, '\n');
strbuf_trim(&confirm);
putchar('\n');
--
1.8.3.rc0.364.gbb5463f
next prev parent reply other threads:[~2013-05-02 13:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 8:07 [PATCH] clean: confirm before cleaning files and directories Jiang Xin
2013-04-26 8:21 ` Matthieu Moy
2013-04-26 8:41 ` Jiang Xin
2013-04-26 8:51 ` Matthieu Moy
2013-04-26 10:00 ` Jiang Xin
2013-04-26 8:53 ` Thomas Rast
2013-04-26 16:10 ` Junio C Hamano
2013-04-26 16:19 ` Matthieu Moy
2013-04-26 17:07 ` Junio C Hamano
2013-04-26 19:06 ` Junio C Hamano
2013-04-27 2:09 ` Jiang Xin
2013-04-27 16:13 ` [PATCH v2] Add support for -i/--interactive to git-clean Jiang Xin
2013-04-27 21:41 ` Matthieu Moy
2013-04-27 23:11 ` Junio C Hamano
2013-04-28 2:03 ` Eric Sunshine
2013-04-29 8:03 ` Matthieu Moy
2013-04-29 14:30 ` [PATCH] clean: Introduce -z for machine readable output Michael J Gruber
2013-04-29 14:45 ` Matthieu Moy
2013-04-29 16:15 ` [PATCH v2] Add support for -i/--interactive to git-clean Jiang Xin
2013-04-30 19:25 ` [PATCH v3] " Jiang Xin
2013-05-01 15:12 ` Matthieu Moy
2013-05-02 13:15 ` [PATCH v4 1/3] " Jiang Xin
2013-05-02 13:15 ` [PATCH v4 2/3] Show items of interactive git-clean in columns Jiang Xin
2013-05-02 15:03 ` Matthieu Moy
2013-05-03 1:26 ` Jiang Xin
2013-05-03 12:54 ` Matthieu Moy
2013-05-02 13:15 ` Jiang Xin [this message]
2013-05-02 15:07 ` [PATCH v4 3/3] Add colors to interactive git-clean Matthieu Moy
2013-05-03 2:53 ` Jiang Xin
2013-05-02 13:43 ` [PATCH v3] Add support for -i/--interactive to git-clean Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5463fa4ef09df08ad3bf5abf4660a5df414e64.1367500374.git.worldhello.net@gmail.com \
--to=worldhello.net@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).