From: "Alexander Gavrilov" <angavrilov@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.
Date: Wed, 22 Oct 2008 12:35:17 +0400 [thread overview]
Message-ID: <bb6f213e0810220135hd520f78odb83414c248a15e4@mail.gmail.com> (raw)
In-Reply-To: <20081022082016.GA18473@sigill.intra.peff.net>
On Wed, Oct 22, 2008 at 12:20 PM, Jeff King <peff@peff.net> wrote:
> On Wed, Oct 22, 2008 at 12:55:57AM +0400, Alexander Gavrilov wrote:
>
>> +test_expect_success \
>> + 'blame respects i18n.commitencoding' '
>> + git blame --incremental file | \
>> + grep "^\(author\|summary\) " > actual &&
>> + test_cmp actual expected
>
> Even though it is POSIX, using backslashed grouping in 'grep' isn't
> portable. It fails at least on Solaris 8, and you have to do:
>
> egrep "^(author|summary) "
>
> instead. Of course, I can't get your test to pass even with that change,
> but I think that is just a broken iconv on Solaris.
Hm, which of the conversions fail? You can try manually converting the
txt files with the iconv command to figure it out.
Alexander
next prev parent reply other threads:[~2008-10-22 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 20:55 [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules Alexander Gavrilov
2008-10-22 8:20 ` Jeff King
2008-10-22 8:35 ` Alexander Gavrilov [this message]
2008-10-22 8:50 ` Jeff King
2008-10-22 9:32 ` Alexander Gavrilov
2008-10-22 12:39 ` Jeff King
2008-10-22 19:07 ` Junio C Hamano
2008-10-22 19:14 ` Jeff King
2008-10-22 19:22 ` Jeff King
2008-10-22 20:29 ` Johannes Schindelin
2008-10-22 20:40 ` Jeff King
2008-10-22 20:12 ` Jakub Narebski
2008-10-22 20:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6f213e0810220135hd520f78odb83414c248a15e4@mail.gmail.com \
--to=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).