git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Crane <git@aaroncrane.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
	Jacob Helwig <jacob.helwig@gmail.com>,
	David Aguilar <davvid@gmail.com>,
	Jay Soffian <jaysoffian@gmail.com>
Subject: Re: [PATCH] Documentation/SubmittingPatches: fix Gmail workaround  advice
Date: Sun, 7 Feb 2010 20:03:31 +0000	[thread overview]
Message-ID: <bc341e101002071203x52bceaach8d42c6188630f1d1@mail.gmail.com> (raw)
In-Reply-To: <7v8wb4gaef.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> Aaron Crane <git@aaroncrane.co.uk> writes:
>> The suggested approach to dealing with Gmail's propensity for breaking
>> patches doesn't seem to work.  Recommend an alternative technique which
>> does.
>
> Do you know _why_ it does not work?  For example, does it not work _at
> all_ for you?  Or only certain things does not reliably work (iow, perhaps
> you are seeing a bug in imap-send)?

What happens for me is that `git imap-send` successfully puts the
message into the gmail Drafts folder, but when it's sent it's been
line-wrapped (and any line-end spaces are deleted, which breaks diffs
containing empty context lines).

I've verified that it's not `git imap-send` at fault, by tweaking it
to tee all socket-written data to a local file; all whitespace in the
mail prepared locally is sent to Gmail unchanged.  So Gmail is
mangling the message when it gets uploaded (or possibly when it's
opened in the web interface, or when it's sent).

I've tried this both with a vanilla Gmail account, and with Google
Apps For Your Domain Standard Edition, and I get the same behaviour.

> What I am trying to get at is to see if the current imap-send suggestion
> is fundamentally unworkable with gmail.  Perhaps they stopped supporting
> imap.  Perhaps the procedure never worked.

As far as I can determine, the current imap-send suggestion is
fundamentally unworkable with gmail at the moment.  I don't know
whether it ever used to work, though I've been assuming that it did.

-- 
Aaron Crane ** http://aaroncrane.co.uk/

  reply	other threads:[~2010-02-07 20:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 15:14 [PATCH] Documentation/SubmittingPatches: fix Gmail workaround advice Aaron Crane
2010-02-07 18:01 ` Jay Soffian
2010-02-07 18:37 ` Junio C Hamano
2010-02-07 20:03   ` Aaron Crane [this message]
2010-02-07 21:54     ` Jonathan Nieder
2010-02-07 22:16       ` Jonathan Nieder
2010-02-08 17:42         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc341e101002071203x52bceaach8d42c6188630f1d1@mail.gmail.com \
    --to=git@aaroncrane.co.uk \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.helwig@gmail.com \
    --cc=jaysoffian@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).