From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] blame: move blame_entry duplication to add_blame_entry()
Date: Fri, 10 Mar 2017 17:20:16 +0100 [thread overview]
Message-ID: <bcb26ae4-ea18-b232-a0e6-2877cda7ccc8@web.de> (raw)
In-Reply-To: <20170310083238.hjfnkmcgufi3oehq@sigill.intra.peff.net>
Am 10.03.2017 um 09:32 schrieb Jeff King:
> On Fri, Mar 10, 2017 at 01:12:59AM +0100, René Scharfe wrote:
>
>> All callers of add_blame_entry() allocate and copy the second argument.
>> Let the function do it for them, reducing code duplication.
>
> I assume you found this due to the DUPLICATE() discussion elsewhere.
Indeed, your grep command in that discussion showed them.
René
prev parent reply other threads:[~2017-03-10 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 0:12 [PATCH] blame: move blame_entry duplication to add_blame_entry() René Scharfe
2017-03-10 8:32 ` Jeff King
2017-03-10 16:20 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcb26ae4-ea18-b232-a0e6-2877cda7ccc8@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).