From: Derrick Stolee <stolee@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Lars Schneider" <larsxschneider@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 3/2 for pb/bisect-helper-2] squash! bisect--helper: `bisect_start` shell function partially in C
Date: Mon, 23 Jul 2018 09:24:03 -0400 [thread overview]
Message-ID: <bcecc802-099e-7e7f-d977-e6f545ff2fee@gmail.com> (raw)
In-Reply-To: <20180723130603.22703-1-szeder.dev@gmail.com>
On 7/23/2018 9:06 AM, SZEDER Gábor wrote:
> bisect--helper: use oid_to_hex()
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> builtin/bisect--helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index fc02f889e6..eac4c27787 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -547,7 +547,7 @@ static int bisect_start(struct bisect_terms *terms, int no_checkout,
> if (!get_oid(head, &head_oid) &&
> !starts_with(head, "refs/heads/")) {
> strbuf_reset(&start_head);
> - strbuf_addstr(&start_head, sha1_to_hex(head_oid.hash));
> + strbuf_addstr(&start_head, oid_to_hex(&head_oid));
> } else if (!get_oid(head, &head_oid) &&
> skip_prefix(head, "refs/heads/", &head)) {
> /*
This patch looks obviously correct. Thanks!
-Stolee
next prev parent reply other threads:[~2018-07-23 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:02 [PATCH 0/2] travis-ci: fail if Coccinelle found something to transform SZEDER Gábor
2018-07-23 13:02 ` [PATCH 1/2] travis-ci: run Coccinelle static analysis with two parallel jobs SZEDER Gábor
2018-07-23 13:02 ` [PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform SZEDER Gábor
2018-07-23 13:23 ` Derrick Stolee
2018-07-26 9:08 ` SZEDER Gábor
2018-07-26 16:49 ` Junio C Hamano
2018-07-23 13:06 ` [PATCH 3/2 for pb/bisect-helper-2] squash! bisect--helper: `bisect_start` shell function partially in C SZEDER Gábor
2018-07-23 13:24 ` Derrick Stolee [this message]
2018-07-23 13:25 ` [PATCH 0/2] travis-ci: fail if Coccinelle found something to transform Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcecc802-099e-7e7f-d977-e6f545ff2fee@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=pclouds@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).