From: Mark Levedahl <mlevedahl@gmail.com>
To: git@vger.kernel.org, johannes.schindelin@gmx.de, me@yadavpratyush.com
Subject: BUG: git-gui no longer executes hook scripts
Date: Fri, 15 Sep 2023 12:45:31 -0400 [thread overview]
Message-ID: <bd510f6d-6613-413b-6d64-c3d2fd01d8a9@gmail.com> (raw)
The commit titled "Work around Tcl's default |PATH| lookup",|aae9560,
adds checking on all commands to be executed to assure these are on the
PATH. Any script in .git/hooks is rejected as .git/hooks is not (in
general) on the PATH, even if the entry in .git/hooks is a symlink to a
file on the PATH. Instead, git-gui throws and error without completing
the operation. This is easily demonstrated by say, enabling the
commit-msg script (hooks-commit-msg.sample templates) and attempting a
commit.
|
|I don't have a suggested solution to this: reverting the above commit
will fix this problem, but that commit was made to mitigate a security
issue. Perhaps anything in .git/hooks should be accepted without
further checks?
|
|
|
|Mark
|
next reply other threads:[~2023-09-15 16:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 16:45 Mark Levedahl [this message]
2023-09-15 17:00 ` BUG: git-gui no longer executes hook scripts Junio C Hamano
2023-09-15 17:15 ` Junio C Hamano
2023-09-15 23:33 ` Mark Levedahl
2023-09-16 0:35 ` [PATCH] git-gui - re-enable use of " Mark Levedahl
2023-09-16 17:28 ` Junio C Hamano
2023-09-16 21:01 ` [PATCH v2] " Mark Levedahl
2023-09-16 21:51 ` Junio C Hamano
2023-09-17 19:22 ` Mark Levedahl
2023-09-17 19:24 ` [PATCH] git-gui - use git-hook, honor core.hooksPath Mark Levedahl
2023-09-18 15:27 ` Johannes Schindelin
2023-09-18 15:58 ` Junio C Hamano
2023-09-18 16:25 ` Mark Levedahl
2023-09-18 17:53 ` Junio C Hamano
2023-09-20 13:05 ` Pratyush Yadav
2023-09-20 15:30 ` Mark Levedahl
2023-09-20 16:58 ` Junio C Hamano
2023-09-20 15:49 ` Junio C Hamano
2023-09-18 15:26 ` [PATCH v2] git-gui - re-enable use of hook scripts Johannes Schindelin
2023-09-18 16:04 ` Junio C Hamano
2023-09-20 13:27 ` Pratyush Yadav
2023-09-16 4:45 ` BUG: git-gui no longer executes " Junio C Hamano
2023-09-16 12:56 ` Mark Levedahl
2023-09-16 14:49 ` Mark Levedahl
2023-09-16 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd510f6d-6613-413b-6d64-c3d2fd01d8a9@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).