From: "Sverre Rabbelier" <alturin@gmail.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: git@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
"James Morris" <jmorris@namei.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Willy Tarreau" <w@1wt.eu>,
david@lang.hm, "Stephen Clark" <sclark46@earthlink.net>,
"Evgeniy Polyakov" <johnpol@2ka.mipt.ru>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Tilman Schmidt" <tilman@imap.cc>,
Valdis.Kletnieks@vt.edu, "Mark Lord" <lkml@rtr.ca>,
"David Miller" <davem@davemloft.net>,
jesper.juhl@gmail.com, yoshfuji@linux-ipv6.org, jeff@garzik.org,
netdev@vger.kernel.org, "David Newall" <davidn@davidnewall.com>
Subject: Re: Reporting bugs and bisection
Date: Wed, 16 Apr 2008 21:39:41 +0200 [thread overview]
Message-ID: <bd6139dc0804161239h17e79c70ta5e938619e5743c9@mail.gmail.com> (raw)
In-Reply-To: <20080416132634.GA545@cs181133002.pp.htv.fi>
On Wed, Apr 16, 2008 at 3:26 PM, Adrian Bunk <bunk@kernel.org> wrote:
> On Wed, Apr 16, 2008 at 02:15:22PM +0200, Sverre Rabbelier wrote:
> At least with the data we have currently in git it's impossible to
> figure that out automatically.
I don't quite agree, as I explained in my proposal there are several
ways to detect that a commit was a bugfix. From thereon you can deduct
that if it was a bugfix, that the commit that introduced the fixed
change was a bug! From thereon you can start sifting and get more
confirmations. Junio has made several suggestions as to how this could
be implemented and I'm confident that and algorithm can be devised
that is at least capable of 'guessing' what type a commit is. Aside
from the guessing part I think a lot of information can be gathered
from commit msgs.
Of course, some commits might not be able to be typed (as there might
not be any 'follow up' information on them). Those commits can be
marked as 'unknown' and be ignored. Agreed, should all commits be
'unknown' then the command wouldn't be very useful, but especially on
large repos there is a very large dataset. As the size of the dataset
increases I estimate that the correlation between commits increases
(less commits that add new code which then is never changed
therafter). The higher the degree of correlation between individual
commits the more we can determine about the nature of a commit.
> E.g. if you look at commit f743d04dcfbeda7439b78802d35305781999aa11
> (ide/legacy/q40ide.c: add MODULE_LICENSE), how could you determine
> automatically that it is a bugfix, and the commit that introduced
> the bug?
Well, a dead giveaway would be:
"http://bugzilla.kernel.org/show_bug.cgi?id=10124"
> You can always get some data, but if you want to get usable statistics
> you need explicit tags in the commits, not some algorithm that tries
> to guess.
As said above, I don't agree, you can 'guess' very reliably on a large
dataset. Also, most commits are already 'tagged' in some way or
another. The trick is to find the pattern in this tagging and use it.
I hope this clears things up a bit,
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2008-04-16 19:40 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47FEADCB.7070104@rtr.ca>
[not found] ` <20080413121831.d89dd424.akpm@linux-foundation.org>
[not found] ` <20080413202118.GA29658@2ka.mipt.ru>
[not found] ` <200804132233.50491.rjw@sisk.pl>
[not found] ` <20080413205406.GA9190@2ka.mipt.ru>
[not found] ` <48028830.6020703@earthlink.net>
2008-04-13 23:51 ` Reporting bugs and bisection david
2008-04-14 0:36 ` Jakub Narebski
2008-04-14 4:39 ` Willy Tarreau
2008-04-14 5:39 ` Al Viro
2008-04-14 6:24 ` Andrew Morton
2008-04-14 6:39 ` David Miller
2008-04-14 6:43 ` David Miller
2008-04-14 7:23 ` Al Viro
2008-04-14 7:43 ` Al Viro
2008-04-14 8:04 ` Andrew Morton
2008-04-14 8:30 ` David Miller
2008-04-14 9:06 ` Christoph Hellwig
2008-04-14 9:46 ` Andi Kleen
2008-04-15 5:25 ` Bill Fink
2008-04-14 10:15 ` Andrew Morton
2008-04-14 10:41 ` David Miller
2008-04-14 17:35 ` Roman Shaposhnik
2008-04-14 12:08 ` Adrian Bunk
2008-04-14 14:43 ` Arjan van de Ven
2008-04-14 17:51 ` Andrew Morton
2008-04-14 18:24 ` Arjan van de Ven
2008-04-14 19:30 ` Ilpo Järvinen
2008-04-14 15:54 ` James Morris
2008-04-14 22:01 ` David Miller
2008-04-14 23:05 ` Andrew Morton
2008-04-15 4:55 ` Willy Tarreau
2008-04-15 13:18 ` Work WAS(Re: " jamal
2008-04-15 9:33 ` David Newall
2008-04-15 9:54 ` Michael Kerrisk
2008-04-15 14:04 ` David Newall
2008-04-15 20:51 ` Rafael J. Wysocki
2008-04-16 2:34 ` David Newall
2008-04-16 3:53 ` david
2008-04-16 9:06 ` David Newall
2008-04-16 11:02 ` Andi Kleen
2008-04-16 12:41 ` Stephen Clark
2008-04-16 4:29 ` Willy Tarreau
2008-04-16 12:13 ` Rafael J. Wysocki
2008-04-16 12:15 ` Sverre Rabbelier
2008-04-16 13:26 ` Adrian Bunk
2008-04-16 19:02 ` Andrew Morton
2008-04-16 19:43 ` Sverre Rabbelier
2008-04-16 19:55 ` Adrian Bunk
2008-04-17 13:50 ` J. Bruce Fields
2008-04-17 15:26 ` Adrian Bunk
2008-04-16 19:58 ` Alexey Dobriyan
2008-04-16 20:01 ` Arjan van de Ven
2008-04-16 19:39 ` Sverre Rabbelier [this message]
2008-04-16 20:16 ` Adrian Bunk
2008-04-16 20:53 ` Adrian Bunk
2008-04-16 21:05 ` Sverre Rabbelier
2008-04-16 21:25 ` Adrian Bunk
2008-04-16 20:04 ` Willy Tarreau
2008-04-16 20:55 ` Jakub Narebski
2008-04-16 21:17 ` Jesper Juhl
2008-04-17 17:04 ` David Newall
2008-04-17 19:09 ` Rafael J. Wysocki
2008-04-17 19:35 ` Ray Lee
2008-04-17 19:57 ` Sverre Rabbelier
2008-04-17 20:16 ` Al Viro
2008-04-17 20:38 ` Ray Lee
2008-04-17 20:53 ` Al Viro
2008-04-17 21:01 ` Ray Lee
2008-04-14 19:13 ` Rene Herman
2008-04-14 20:38 ` Andrew Morton
2008-04-14 22:18 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6139dc0804161239h17e79c70ta5e938619e5743c9@mail.gmail.com \
--to=alturin@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=david@lang.hm \
--cc=davidn@davidnewall.com \
--cc=git@vger.kernel.org \
--cc=jeff@garzik.org \
--cc=jesper.juhl@gmail.com \
--cc=jmorris@namei.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sclark46@earthlink.net \
--cc=sverre@rabbelier.nl \
--cc=tilman@imap.cc \
--cc=viro@zeniv.linux.org.uk \
--cc=w@1wt.eu \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).