git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sverre Rabbelier" <alturin@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Asheesh Laroia" <asheesh@asheesh.org>,
	"Clark Williams" <clark.williams@gmail.com>,
	"Catalin Marinas" <catalin.marinas@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH - stgit] Patch to allow import of compressed files
Date: Tue, 10 Jun 2008 12:33:25 +0200	[thread overview]
Message-ID: <bd6139dc0806100333s4395cca4g52b58679d7fc5c25@mail.gmail.com> (raw)
In-Reply-To: <20080610102800.GB30119@diana.vm.bytemark.co.uk>

On Tue, Jun 10, 2008 at 12:28 PM, Karl Hasselström <kha@treskal.com> wrote:
> If there's just one patch in the tar file, why did you use a tar file
> in the first place instead of just gzipping?

I guess mostly habbit :P. Whenever I zip something I create a gzipped
tarball because that's how I usually do it.

> I'm pretty sure that anyone who really has use for the tar-file
> capability would be using tar files with multiple patches in them.

Yeah, I guess that's true for most people indeed.

> I was refering to the fact that due to tar-files in the general case
> containing more than one patch, you'd have to modify the parts of
> imprt.py that deal with importing multiple patches at once, in
> addition to the parts the current patch touches.

Mhhh, yeah, but should be something like
for patch in patches
  applyPatch(patch)

> But you're probably right that the amount of additional work would not
> be much more than what went into the current patch.

To just support .tar, yeah, but let's see what the author has to say
about this ;).

-- 
Cheers,

Sverre Rabbelier

  reply	other threads:[~2008-06-10 10:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 18:38 [PATCH - stgit] Patch to allow import of compressed files Clark Williams
2008-06-10  6:33 ` Karl Hasselström
2008-06-10  6:38   ` Asheesh Laroia
2008-06-10  8:07     ` Sverre Rabbelier
2008-06-10  9:53       ` Karl Hasselström
2008-06-10  9:57         ` Sverre Rabbelier
2008-06-10 10:28           ` Karl Hasselström
2008-06-10 10:33             ` Sverre Rabbelier [this message]
2008-06-10 14:06               ` Clark Williams
2008-06-10 14:01       ` Clark Williams
2008-06-10 13:57     ` Clark Williams
2008-06-10 14:04       ` Asheesh Laroia
2008-06-10 13:54   ` Clark Williams
2008-06-10 13:54   ` Clark Williams
2008-06-11  6:27     ` Karl Hasselström
2008-06-11 17:28       ` Clark Williams
2008-06-11 19:14         ` Karl Hasselström
2008-06-19 14:17   ` David Kågedal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd6139dc0806100333s4395cca4g52b58679d7fc5c25@mail.gmail.com \
    --to=alturin@gmail.com \
    --cc=asheesh@asheesh.org \
    --cc=catalin.marinas@gmail.com \
    --cc=clark.williams@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=sverre@rabbelier.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).