git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sverre Rabbelier" <alturin@gmail.com>
To: "Daniel Barkalow" <barkalow@iabervon.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Only use GIT_CONFIG in "git config", not other programs
Date: Tue, 15 Jul 2008 19:56:01 +0200	[thread overview]
Message-ID: <bd6139dc0807151056q61a9379l84761fe021d4541c@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.00.0806300328380.19665@iabervon.org>

On Mon, Jun 30, 2008 at 9:37 AM, Daniel Barkalow <barkalow@iabervon.org> wrote:
> @@ -611,31 +613,28 @@ int git_config(config_fn_t fn, void *data)
>  {
>        int ret = 0;
>        char *repo_config = NULL;
> -       const char *home = NULL, *filename;
> +       const char *home = NULL;
>
>        /* $GIT_CONFIG makes git read _only_ the given config file,
>         * $GIT_CONFIG_LOCAL will make it process it in addition to the
>         * global config file, the same way it would the per-repository
>         * config file otherwise. */

I noticed today while looking at config.c (because of the 'git config
oddity' thread) that this reference to GIT_CONFIG_LOCAL was not
removed? On latest next:
$ grep GIT_CONFIG_LOCAL *
config.c:	 * $GIT_CONFIG_LOCAL will make it process it in addition to the
git-svn:		my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||
git-svn.perl:		my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||

I doubt that this stray comment will hurt anyone, but it's probably
nicer not to let cruft like this accumulate, I think?

-- 
Cheers,

Sverre Rabbelier

  parent reply	other threads:[~2008-07-15 17:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30  7:37 [PATCH] Only use GIT_CONFIG in "git config", not other programs Daniel Barkalow
2008-06-30  7:57 ` Junio C Hamano
2008-06-30 17:28   ` Daniel Barkalow
2008-07-15 17:56 ` Sverre Rabbelier [this message]
2008-07-15 21:46   ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd6139dc0807151056q61a9379l84761fe021d4541c@mail.gmail.com \
    --to=alturin@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sverre@rabbelier.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).