From: "Sverre Rabbelier" <alturin@gmail.com>
To: "Olivier Marin" <dkr+ml.git@free.fr>
Cc: "Pierre Habouzit" <madcoder@debian.org>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] parse-options: fix parsing of "--foobar=" with no value
Date: Tue, 22 Jul 2008 20:53:06 +0200 [thread overview]
Message-ID: <bd6139dc0807221153n18c864b7ve83a316867e892ab@mail.gmail.com> (raw)
In-Reply-To: <1216752267-12138-1-git-send-email-dkr+ml.git@free.fr>
On Tue, Jul 22, 2008 at 8:44 PM, Olivier Marin <dkr+ml.git@free.fr> wrote:
> We should instead, exit with an error if a value is required, or use
> the default one if the value is optional.
This makes no sense, when I run "git foo --bar=" I either mean "set
bar to empty" or I typo-ed. Why would I specify "--bar=" if I want the
default value?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2008-07-22 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 18:44 [PATCH] parse-options: fix parsing of "--foobar=" with no value Olivier Marin
2008-07-22 18:53 ` Sverre Rabbelier [this message]
2008-07-22 18:54 ` Pierre Habouzit
2008-07-22 19:25 ` Olivier Marin
2008-07-22 20:05 ` Johannes Schindelin
2008-07-22 20:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6139dc0807221153n18c864b7ve83a316867e892ab@mail.gmail.com \
--to=alturin@gmail.com \
--cc=dkr+ml.git@free.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=sverre@rabbelier.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).