git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/1] Invalid test preventing a build using maven
Date: Mon, 16 Feb 2009 19:05:23 +0100	[thread overview]
Message-ID: <bd6139dc0902161005x32e6ddccs8cbf9a825fa26c50@mail.gmail.com> (raw)
In-Reply-To: <85647ef50902160946m480542a3m1511366f6cafe04e@mail.gmail.com>

Heya,

On Mon, Feb 16, 2009 at 18:46, Constantine Plotnikov
<constantine.plotnikov@gmail.com> wrote:
> The attached patch ensures that correct UTF-8 character sequence is
> used in the test.

Please follow the guidelines to submitting patches as described in
Documentation/SubmittingPatches (available online at [0]). Doing so
will save the maintainer (in this case Shawn) the time required to
munge your patch into an applyable format. Also, your commit message
is funny in the sense that part of it should go into the actual commit
message, and part of it should go after the triple dashes (also
described in SubmittingPatches).

Good luck :).

[0] http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD

-- 
Cheers,

Sverre Rabbelier

      reply	other threads:[~2009-02-16 18:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16 17:46 [JGIT PATCH 1/1] Invalid test preventing a build using maven Constantine Plotnikov
2009-02-16 18:05 ` Sverre Rabbelier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd6139dc0902161005x32e6ddccs8cbf9a825fa26c50@mail.gmail.com \
    --to=srabbelier@gmail.com \
    --cc=constantine.plotnikov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).