From: "Jakub Narębski" <jnareb@gmail.com>
To: Eric Wong <e@80x24.org>, larsxschneider@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, tboegi@web.de,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v1 1/2] sha1_file: open window into packfiles with CLOEXEC
Date: Tue, 6 Sep 2016 11:36:33 +0200 [thread overview]
Message-ID: <bd9fc74b-b9b0-7c09-9c22-02b6f0f3cec9@gmail.com> (raw)
In-Reply-To: <20160905222715.GA30031@starla>
W dniu 06.09.2016 o 00:27, Eric Wong pisze:
> larsxschneider@gmail.com wrote:
>> -int git_open_noatime(const char *name)
>> +int git_open_noatime_cloexec(const char *name)
[...]
>
> I question the need for the "_cloexec" suffixing in the
> function name since the old function is going away entirely.
On the other hand the new name is descriptive...
>
> I prefer all FD-creating functions set cloexec by default
> for FD > 2 to avoid inadvertantly leaking FDs. So we
> ought to use pipe2, accept4, socket(..., SOCK_CLOEXEC), etc...
> and fallback to the racy+slower F_SETFD when not available.
>
>
> Fwiw, Perl has been setting cloexec on FDs above $^F
> (2, $SYSTEM_FD_MAX) for decades, and Ruby started
> doing it a few years ago, too.
next prev parent reply other threads:[~2016-09-06 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 21:11 [PATCH v1 0/2] Use CLOEXEC to avoid fd leaks larsxschneider
2016-09-05 21:11 ` [PATCH v1 1/2] sha1_file: open window into packfiles with CLOEXEC larsxschneider
2016-09-05 22:27 ` Eric Wong
2016-09-06 9:36 ` Jakub Narębski [this message]
2016-09-06 11:38 ` Johannes Schindelin
2016-09-07 13:20 ` Lars Schneider
2016-09-07 18:17 ` Eric Wong
2016-09-05 21:11 ` [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes larsxschneider
2016-09-06 11:41 ` Johannes Schindelin
2016-09-06 21:06 ` Eric Wong
2016-09-07 13:39 ` Lars Schneider
2016-09-07 18:10 ` Eric Wong
2016-09-07 18:23 ` Junio C Hamano
2016-09-08 5:57 ` Lars Schneider
2016-09-08 17:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9fc74b-b9b0-7c09-9c22-02b6f0f3cec9@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).