From: Sebastian Schuberth <sschuberth@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
jugg@hotmail.com
Subject: Re: [PATCH] If deriving SVN_SSH from GIT_SSH on msys, also add quotes
Date: Sat, 23 Jan 2010 21:11:17 +0100 [thread overview]
Message-ID: <bdca99241001231211o97aa0eamacc40bf982a9f022@mail.gmail.com> (raw)
In-Reply-To: <7vd410d3as.fsf@alter.siamese.dyndns.org>
On Sat, Jan 23, 2010 at 20:33, Junio C Hamano <gitster@pobox.com> wrote:
>> This fixes msysGit issue 385, see
>> http://code.google.com/p/msysgit/issues/detail?id=385
>>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>
> As the patch clearly is inside "msys-only" codepath, I don't mind
> bypassing Eric and apply this directly to my tree before I tag 1.7.0-rc0,
> but may I ask why this quoting magic matters only on msys?
To be honest, I'm not exactly sure why this is required. Maybe the SVN
Perl module does some different path mangling than a normal MSYS SVN
binary would do. We're already setting SVN_SSH like this (that is,
using double-backslashes and quotes) in the msysGit installer, see the
discussion at [1]. This patch basically just does the same thing for
people that initially chose to not modify the environment during the
msysGit installation, but later change GIT_SSH manually, and forget to
set SVN_SSH, too.
[1] http://code.google.com/p/msysgit/issues/detail?id=305#c8
--
Sebastian Schuberth
prev parent reply other threads:[~2010-01-23 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 10:22 [PATCH] If deriving SVN_SSH from GIT_SSH on msys, also add quotes Sebastian Schuberth
2010-01-23 11:22 ` Sverre Rabbelier
2010-01-23 14:20 ` Sebastian Schuberth
2010-01-23 19:33 ` Junio C Hamano
2010-01-23 20:11 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdca99241001231211o97aa0eamacc40bf982a9f022@mail.gmail.com \
--to=sschuberth@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jugg@hotmail.com \
--cc=normalperson@yhbt.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).