git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Andrew Kreimer" <algonell@gmail.com>, "Taylor Blau" <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t: fix typos
Date: Fri, 18 Oct 2024 18:58:48 +0200	[thread overview]
Message-ID: <be0c95ee-1d9f-4e97-9710-0ceba9c3aaed@app.fastmail.com> (raw)
In-Reply-To: <ZxKSFBl_pV2r99dY@void.void>

On Fri, Oct 18, 2024, at 18:51, Andrew Kreimer wrote:
> On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:
>> Please do not base new topics on 'seen', as it is likely to change
>> day-to-day.
>>
>
> Noted, thank you.
>
>> > @@ -117,7 +117,7 @@ do
>> >  		git config extensions.objectformat $hash &&
>> >  		git config extensions.compatobjectformat $(compat_hash $hash) &&
>> >  		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
>> > -		echo "Hellow World!" > hello &&
>> > +		echo "Hello World!" > hello &&
>>
>> Not the fault of this patch, but there is a style issue here that there
>> should not be a space between '>' and 'hello' (i.e. it should read
>> '>hello', not '> hello').
>>
>
> Do you mean that '> more' and '> another' should be handled similarly?

What do these two refer to?

The code style says that redirection operators should have no space
after them.  See Documentation/CodingGuidelines at “Redirection
operators”.

-- 
Kristoffer Haugsbakk



  reply	other threads:[~2024-10-18 16:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 11:28 [PATCH] t: fix typos Andrew Kreimer
2024-10-17 20:23 ` Taylor Blau
2024-10-18 16:51   ` Andrew Kreimer
2024-10-18 16:58     ` Kristoffer Haugsbakk [this message]
2024-10-18 18:03       ` Andrew Kreimer
2024-10-18 21:05         ` Taylor Blau
2024-10-18 21:06           ` Taylor Blau
2024-10-18 21:41             ` Taylor Blau
2024-10-19 13:08               ` Andrew Kreimer
  -- strict thread matches above, loose matches on Subject: below --
2024-10-23 17:01 Andrew Kreimer
2024-10-23 18:00 ` Kristoffer Haugsbakk
2024-10-23 18:33   ` Taylor Blau
2024-10-24 11:44     ` Andrew Kreimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0c95ee-1d9f-4e97-9710-0ceba9c3aaed@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=algonell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).