From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "ZheNing Hu" <adlternative@gmail.com>
Subject: Re: [PATCH] doc: interpret-trailers: fix cmd examples
Date: Tue, 29 Sep 2026 21:10:48 +0200 [thread overview]
Message-ID: <be487f47-054c-443f-b5cb-b612269fedba@app.fastmail.com> (raw)
In-Reply-To: <xmqqh5j9mdpx.fsf@gitster.g>
On Mon, Sep 28, 2026, at 20:29, Junio C Hamano wrote:
> kristofferhaugsbakk@fastmail.com writes:
>
>> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>>
>> Fix `trailer.<key-alias>.cmd` examples which have remained unchanged
>> since they were written in c364b7ef (trailer: add new .cmd config
>> option, 2021-05-03). (Modulo formatting changes.)
>>
>> Use this example as a guide for how to phrase it:
>>
>> Configure a `see` trailer with a command to show the subject of a
>> commit that is related, and show how it works:
>
> This read as if you are declaring that you use a template that
> invented to consistently give intro for each example, and made it
> look like the use of `see` was as a placeholder. It would have
> avoided the "Huh?" reaction if it were phrased like so:
>
> Steal how example to show the `see` trailer is phrased and use
> it throughout:
>
> Configure a `see` trailer ...
>
> Other than that, this looks good.
I’ll make that change.
next prev parent reply other threads:[~2026-09-29 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 14:12 [PATCH] doc: interpret-trailers: fix cmd examples kristofferhaugsbakk
2026-09-28 18:29 ` Junio C Hamano
2026-09-29 19:10 ` Kristoffer Haugsbakk [this message]
2026-10-03 16:03 ` [PATCH v2] " kristofferhaugsbakk
2026-10-04 16:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be487f47-054c-443f-b5cb-b612269fedba@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox