From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Jeff King" <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org, git@jowil.de
Subject: Re: [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname
Date: Mon, 02 Dec 2024 22:09:57 +0100 [thread overview]
Message-ID: <be4dccb2-70f1-4687-a052-caeb86e4e1c7@app.fastmail.com> (raw)
In-Reply-To: <20241202210006.GE776185@coredump.intra.peff.net>
On Mon, Dec 2, 2024, at 22:00, Jeff King wrote:
> On Mon, Dec 02, 2024 at 01:19:56PM +0100, Kristoffer Haugsbakk wrote:
>
>> On Mon, Dec 2, 2024, at 08:07, Junio C Hamano wrote:
>> > 09116a1c (refs: loosen over-strict "format" check, 2011-11-16)
>>
>> Nit/confusion: the abbreviated hash is only eight hexes long. I’m used to it
>> being 11 for this project?
>
> It's not a fixed size. Long ago, the rule was "enough to be unique, but
> at least 7 (or whatever you set core.abbrev to)". These days that "7" is
> scaled based on the number of objects in the repo. See e6c587c733
> (abbrev: auto size the default abbreviation, 2016-09-30).
Yes. 11 was based on the output I get as well as what seemed normal in the
recent git log.
>
> So I'd expect 10 digits in a fresh clone of git.git. It's possible Junio
> has set core.abbrev to something fixed, though.
>
>> Does the age of the commit matter?
>
> Nope, it shouldn't.
Makes sense. Thanks.
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-12-02 21:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 7:07 [PATCH 0/4] forbid HEAD as a tagname Junio C Hamano
2024-12-02 7:07 ` [PATCH 1/4] refs: move ref name helpers around Junio C Hamano
2024-12-02 20:37 ` Jeff King
2024-12-03 1:23 ` Junio C Hamano
2024-12-02 7:07 ` [PATCH 2/4] refs: drop strbuf_ prefix from helpers Junio C Hamano
2024-12-02 20:51 ` Jeff King
2024-12-02 7:07 ` [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname Junio C Hamano
2024-12-02 12:19 ` Kristoffer Haugsbakk
2024-12-02 21:00 ` Jeff King
2024-12-02 21:09 ` Kristoffer Haugsbakk [this message]
2024-12-03 1:29 ` Junio C Hamano
2024-12-05 20:25 ` Jeff King
2024-12-02 20:52 ` Jeff King
2024-12-02 7:07 ` [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname Junio C Hamano
2024-12-02 10:54 ` Patrick Steinhardt
2024-12-02 13:01 ` shejialuo
2024-12-03 1:30 ` Junio C Hamano
2024-12-05 20:26 ` Jeff King
2024-12-05 20:27 ` Jeff King
2024-12-02 20:42 ` Rubén Justo
2024-12-03 1:35 ` Junio C Hamano
2024-12-02 21:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4dccb2-70f1-4687-a052-caeb86e4e1c7@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=git@jowil.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).