git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: Mike Hommey <mh@glandium.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] http-push.c: get_remote_object_url() is only used under  USE_CURL_MULTI
Date: Tue, 3 Feb 2009 18:40:16 +0800	[thread overview]
Message-ID: <be6fef0d0902030240g13672ef4uda2f70443ecfabf7@mail.gmail.com> (raw)
In-Reply-To: <20090203065457.GA8466@glandium.org>

On Tue, Feb 3, 2009 at 2:54 PM, Mike Hommey <mh@glandium.org> wrote:
> If I recall correctly, http-push just doesn't work without curl-multi,
> so the correct fix would be to just disable http-push when
> USE_CURL_MULTI is undefined.

Indeed, it dies on line 2253 (18d81a).

2252 #ifndef USE_CURL_MULTI
2253         die("git-push is not available for http/https repository
when not compiled with USE_CURL_MULTI");
2254 #endif

-- 
Cheers,
Ray Chuan

      reply	other threads:[~2009-02-03 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03  6:45 [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI Junio C Hamano
2009-02-03  6:54 ` Mike Hommey
2009-02-03 10:40   ` Tay Ray Chuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be6fef0d0902030240g13672ef4uda2f70443ecfabf7@mail.gmail.com \
    --to=rctay89@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mh@glandium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).