From: Tay Ray Chuan <rctay89@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH 15/18] http*: add http_get_info_packs
Date: Fri, 29 May 2009 22:39:22 +0800 [thread overview]
Message-ID: <be6fef0d0905290739s125296f1m5eedfde8299f27e9@mail.gmail.com> (raw)
In-Reply-To: <7veiuetenn.fsf@alter.siamese.dyndns.org>
Hi,
On Mon, May 25, 2009 at 4:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
> It makes me wonder if fetch_index(), even though it is static to http.c,
> should be renamed somehow to reduce confusion between it and
> fetch_http_pack_index().
Indeed. What I'm now doing is
fetch_index --> fetch_pack_index
setup_index --> fetch_and_setup_pack_index
> You have decl-after-statement and a handful of variable that are no longer
> used. Please squash this in when rerolling.
>
> http-push.c | 2 --
> http-walker.c | 1 -
> http.c | 10 +++-------
> 3 files changed, 3 insertions(+), 10 deletions(-)
Thanks for including a patch.
--
Cheers,
Ray Chuan
prev parent reply other threads:[~2009-05-29 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 14:20 [PATCH 15/18] http*: add http_get_info_packs Tay Ray Chuan
2009-05-24 20:43 ` Junio C Hamano
2009-05-29 14:39 ` Tay Ray Chuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d0905290739s125296f1m5eedfde8299f27e9@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).