From: Tay Ray Chuan <rctay89@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url
Date: Sat, 6 Jun 2009 09:04:35 +0800 [thread overview]
Message-ID: <be6fef0d0906051804k4d574d39v37dedf46896cb570@mail.gmail.com> (raw)
In-Reply-To: <m3my8m5ryh.fsf@localhost.localdomain>
Hi,
On Sat, Jun 6, 2009 at 4:46 AM, Jakub Narebski<jnareb@gmail.com> wrote:
>> From: Mike Hommey <mh@glandium.org>
>> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
>
> So what is the title of this patch? "transport.c::get_refs_via_curl():
> do not leak refs_url" or "Some cleanup in get_refs_via_curl()"?
See my reply to patch #19.
> Perhaps it should be "transport.c: Do not leak refs_url in
> get_refs_via_curl()"...?
I think it's a matter of preference. I'll put them side-by-side to
demonstrate this better:
transport.c: Do not leak refs_url in get_refs_via_curl()
transport.c::get_refs_via_curl(): do not leak refs_url
There isn't any important difference between the two other than form.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2009-06-06 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 16:04 [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url Tay Ray Chuan
2009-06-05 20:46 ` Jakub Narebski
2009-06-06 1:04 ` Tay Ray Chuan [this message]
[not found] <cover.1244277116.git.rctay89@gmail.com>
2009-06-06 8:43 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d0906051804k4d574d39v37dedf46896cb570@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).