From: Tay Ray Chuan <rctay89@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] remote-curl.c: fix rpc_out()
Date: Tue, 24 Nov 2009 09:35:51 +0800 [thread overview]
Message-ID: <be6fef0d0911231735g416d028al1821668be295fe6a@mail.gmail.com> (raw)
In-Reply-To: <20091123210415.GH11919@spearce.org>
Hi,
On Tue, Nov 24, 2009 at 5:04 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> If I understand the change right, the only thing that really matters
> here is removing the extra ';' in the if (max < avail) condition.
>
> That bug was the only reason why rpc->len < rpc->pos, and is thus
> the only reason why avail would "go negative" (which it can't do
> since its unsigned, it just wrapped around to a massive value).
> [snip]
> Right. This bug is really bad and should be fixed. But the message
> above make this some little after-thought and doesn't explain what
> was wrong with this being here.
point noted.
--
Cheers,
Ray Chuan
prev parent reply other threads:[~2009-11-24 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 3:03 [PATCH 2/2] remote-curl.c: fix rpc_out() Tay Ray Chuan
2009-11-23 5:53 ` Sverre Rabbelier
2009-11-23 8:38 ` Tay Ray Chuan
2009-11-23 10:39 ` Johannes Schindelin
2009-11-23 17:54 ` Tay Ray Chuan
2009-11-23 21:04 ` Shawn O. Pearce
2009-11-24 1:35 ` Tay Ray Chuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d0911231735g416d028al1821668be295fe6a@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).